From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve node type forward reference
Date: Thu, 17 Oct 2024 06:39:35 +0000
Message-ID: <E1t1KAa-001CF0-Ev@gemulon.postgresql.org> (raw)
Improve node type forward reference
Instead of using Node *, we can use an incomplete struct. That way,
everything has the correct type and fewer casts are required. This
technique is already used elsewhere in node type definitions.
Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Tender Wang <tndrwang@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/637eeea8-5663-460b-a114-39572c0f6c6e%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/eafda78fc404c706da4cfa254dafb3e97f6cd111
Modified Files
--------------
src/backend/commands/createas.c | 2 +-
src/backend/parser/analyze.c | 2 +-
src/include/nodes/primnodes.h | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve node type forward reference
In-Reply-To: <E1t1KAa-001CF0-Ev@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox