pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: ecpg: Refactor ecpg_log() to skip unnecessary calls to ECPGget_s
Date: Tue, 22 Oct 2024 14:58:42 +0000
Message-ID: <E1t3GLK-001vDi-G2@gemulon.postgresql.org> (raw)

ecpg: Refactor ecpg_log() to skip unnecessary calls to ECPGget_sqlca().

Previously, ecpg_log() always called ECPGget_sqlca() to retrieve sqlca,
even though it was only needed for debug logging. This commit updates
ecpg_log() to call ECPGget_sqlca() only when debug logging is enabled.

Author: Yuto Sasaki
Reviewed-by: Alvaro Herrera, Tom Lane, Fujii Masao
Discussion: https://postgr.es/m/TY2PR01MB3628A85689649BABC9A1C6C3C1782@TY2PR01MB3628.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7c4d3fe272f3ab62b36f21e3fa6ae00751f00e31

Modified Files
--------------
src/interfaces/ecpg/ecpglib/misc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



Message-ID: <E1t3GLK-001vDi-G2@gemulon.postgresql.org>
Permalink:  ../E1t3GLK-001vDi-G2@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1t3GLK-001vDi-G2@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: ecpg: Refactor ecpg_log() to skip unnecessary calls to ECPGget_s
  In-Reply-To: <E1t3GLK-001vDi-G2@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox