pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Move LSN waiting declarations and definitions to better place
Date: Thu, 24 Oct 2024 12:04:14 +0000
Message-ID: <E1t3wZa-002Dta-Nm@gemulon.postgresql.org> (raw)

Move LSN waiting declarations and definitions to better place

3c5db1d6b implemented the pg_wal_replay_wait() stored procedure.  Due to
the patch development history, the implementation resided in
src/backend/commands/waitlsn.c (src/include/commands/waitlsn.h for headers).

014f9f34d moved pg_wal_replay_wait() itself to
src/backend/access/transam/xlogfuncs.c near to the WAL-manipulation functions.
But most of the implementation stayed in place.

The code in src/backend/commands/waitlsn.c has nothing to do with commands,
but is related to WAL.  So, this commit moves this code into
src/backend/access/transam/xlogwait.c (src/include/access/xlogwait.h for
headers).

Reported-by: Peter Eisentraut
Discussion: https://postgr.es/m/18c0fa64-0475-415e-a1bd-665d922c5201%40eisentraut.org
Reviewed-by: Pavel Borisov

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5035172e4ab58e4e8eef1bc60b0712fc59e0be31

Modified Files
--------------
src/backend/access/transam/Makefile                           |  3 ++-
src/backend/access/transam/meson.build                        |  1 +
src/backend/access/transam/xact.c                             |  2 +-
src/backend/access/transam/xlog.c                             |  2 +-
src/backend/access/transam/xlogfuncs.c                        |  2 +-
src/backend/access/transam/xlogrecovery.c                     |  2 +-
src/backend/{commands/waitlsn.c => access/transam/xlogwait.c} |  6 +++---
src/backend/commands/Makefile                                 |  3 +--
src/backend/commands/meson.build                              |  1 -
src/backend/storage/ipc/ipci.c                                |  2 +-
src/backend/storage/lmgr/proc.c                               |  2 +-
src/include/{commands/waitlsn.h => access/xlogwait.h}         | 10 +++++-----
12 files changed, 18 insertions(+), 18 deletions(-)



Message-ID: <E1t3wZa-002Dta-Nm@gemulon.postgresql.org>
Permalink:  ../E1t3wZa-002Dta-Nm@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1t3wZa-002Dta-Nm@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Move LSN waiting declarations and definitions to better place
  In-Reply-To: <E1t3wZa-002Dta-Nm@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox