From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: At end of recovery, reset all sinval-managed caches.
Date: Fri, 25 Oct 2024 13:51:48 +0000
Message-ID: <E1t4KjF-002OMi-4N@gemulon.postgresql.org> (raw)
At end of recovery, reset all sinval-managed caches.
An inplace update's invalidation messages are part of its transaction's
commit record. However, the update survives even if its transaction
aborts or we stop recovery before replaying its transaction commit.
After recovery, a backend that started in recovery could update the row
without incorporating the inplace update. That could result in a table
with an index, yet relhasindex=f. That is a source of index corruption.
This bulk invalidation avoids the functional consequences. A future
change can fix the !RecoveryInProgress() scenario without changing the
WAL format. Back-patch to v17 - v12 (all supported versions). v18 will
instead add invalidations to WAL.
Discussion: https://postgr.es/m/20240618152349.7f.nmisch@google.com
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d36b4d8ec3227c1406c2a3e046153b32b33cecd8
Modified Files
--------------
src/backend/access/transam/xlog.c | 25 ++++++++++++++++++++++
src/backend/storage/ipc/sinvaladt.c | 41 +++++++++++++++++++++++++++++++++++++
src/include/storage/sinvaladt.h | 1 +
3 files changed, 67 insertions(+)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: At end of recovery, reset all sinval-managed caches.
In-Reply-To: <E1t4KjF-002OMi-4N@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox