pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: At end of recovery, reset all sinval-managed caches. 6+ messages / 1 participants [nested] [flat]
* pgsql: At end of recovery, reset all sinval-managed caches. @ 2024-10-25 13:51 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-10-25 13:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org At end of recovery, reset all sinval-managed caches. An inplace update's invalidation messages are part of its transaction's commit record. However, the update survives even if its transaction aborts or we stop recovery before replaying its transaction commit. After recovery, a backend that started in recovery could update the row without incorporating the inplace update. That could result in a table with an index, yet relhasindex=f. That is a source of index corruption. This bulk invalidation avoids the functional consequences. A future change can fix the !RecoveryInProgress() scenario without changing the WAL format. Back-patch to v17 - v12 (all supported versions). v18 will instead add invalidations to WAL. Discussion: https://postgr.es/m/20240618152349.7f.nmisch@google.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/67f30c79a1c17417029b3c1cd1d94aa56d5fb691 Modified Files -------------- src/backend/access/transam/xlog.c | 25 ++++++++++++++++++++++ src/backend/storage/ipc/sinvaladt.c | 41 +++++++++++++++++++++++++++++++++++++ src/include/storage/sinvaladt.h | 1 + 3 files changed, 67 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: At end of recovery, reset all sinval-managed caches. @ 2024-10-25 13:51 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-10-25 13:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org At end of recovery, reset all sinval-managed caches. An inplace update's invalidation messages are part of its transaction's commit record. However, the update survives even if its transaction aborts or we stop recovery before replaying its transaction commit. After recovery, a backend that started in recovery could update the row without incorporating the inplace update. That could result in a table with an index, yet relhasindex=f. That is a source of index corruption. This bulk invalidation avoids the functional consequences. A future change can fix the !RecoveryInProgress() scenario without changing the WAL format. Back-patch to v17 - v12 (all supported versions). v18 will instead add invalidations to WAL. Discussion: https://postgr.es/m/20240618152349.7f.nmisch@google.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d36b4d8ec3227c1406c2a3e046153b32b33cecd8 Modified Files -------------- src/backend/access/transam/xlog.c | 25 ++++++++++++++++++++++ src/backend/storage/ipc/sinvaladt.c | 41 +++++++++++++++++++++++++++++++++++++ src/include/storage/sinvaladt.h | 1 + 3 files changed, 67 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: At end of recovery, reset all sinval-managed caches. @ 2024-10-25 13:51 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-10-25 13:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org At end of recovery, reset all sinval-managed caches. An inplace update's invalidation messages are part of its transaction's commit record. However, the update survives even if its transaction aborts or we stop recovery before replaying its transaction commit. After recovery, a backend that started in recovery could update the row without incorporating the inplace update. That could result in a table with an index, yet relhasindex=f. That is a source of index corruption. This bulk invalidation avoids the functional consequences. A future change can fix the !RecoveryInProgress() scenario without changing the WAL format. Back-patch to v17 - v12 (all supported versions). v18 will instead add invalidations to WAL. Discussion: https://postgr.es/m/20240618152349.7f.nmisch@google.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3baf804b7295fff7551f93ed94550d8268804cc1 Modified Files -------------- src/backend/access/transam/xlog.c | 25 ++++++++++++++++++++++ src/backend/storage/ipc/sinvaladt.c | 41 +++++++++++++++++++++++++++++++++++++ src/include/storage/sinvaladt.h | 1 + 3 files changed, 67 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: At end of recovery, reset all sinval-managed caches. @ 2024-10-25 13:51 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-10-25 13:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org At end of recovery, reset all sinval-managed caches. An inplace update's invalidation messages are part of its transaction's commit record. However, the update survives even if its transaction aborts or we stop recovery before replaying its transaction commit. After recovery, a backend that started in recovery could update the row without incorporating the inplace update. That could result in a table with an index, yet relhasindex=f. That is a source of index corruption. This bulk invalidation avoids the functional consequences. A future change can fix the !RecoveryInProgress() scenario without changing the WAL format. Back-patch to v17 - v12 (all supported versions). v18 will instead add invalidations to WAL. Discussion: https://postgr.es/m/20240618152349.7f.nmisch@google.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dca68242a81b39672557b77c72ce15790bf0f7fe Modified Files -------------- src/backend/access/transam/xlog.c | 25 ++++++++++++++++++++++ src/backend/storage/ipc/sinvaladt.c | 41 +++++++++++++++++++++++++++++++++++++ src/include/storage/sinvaladt.h | 1 + 3 files changed, 67 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: At end of recovery, reset all sinval-managed caches. @ 2024-10-25 13:51 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-10-25 13:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org At end of recovery, reset all sinval-managed caches. An inplace update's invalidation messages are part of its transaction's commit record. However, the update survives even if its transaction aborts or we stop recovery before replaying its transaction commit. After recovery, a backend that started in recovery could update the row without incorporating the inplace update. That could result in a table with an index, yet relhasindex=f. That is a source of index corruption. This bulk invalidation avoids the functional consequences. A future change can fix the !RecoveryInProgress() scenario without changing the WAL format. Back-patch to v17 - v12 (all supported versions). v18 will instead add invalidations to WAL. Discussion: https://postgr.es/m/20240618152349.7f.nmisch@google.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/da9950456463456b8e2c38f5a09bf33fe958a595 Modified Files -------------- src/backend/access/transam/xlog.c | 25 ++++++++++++++++++++++ src/backend/storage/ipc/sinvaladt.c | 41 +++++++++++++++++++++++++++++++++++++ src/include/storage/sinvaladt.h | 1 + 3 files changed, 67 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: At end of recovery, reset all sinval-managed caches. @ 2024-10-25 13:51 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 6+ messages in thread From: Noah Misch @ 2024-10-25 13:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org At end of recovery, reset all sinval-managed caches. An inplace update's invalidation messages are part of its transaction's commit record. However, the update survives even if its transaction aborts or we stop recovery before replaying its transaction commit. After recovery, a backend that started in recovery could update the row without incorporating the inplace update. That could result in a table with an index, yet relhasindex=f. That is a source of index corruption. This bulk invalidation avoids the functional consequences. A future change can fix the !RecoveryInProgress() scenario without changing the WAL format. Back-patch to v17 - v12 (all supported versions). v18 will instead add invalidations to WAL. Discussion: https://postgr.es/m/20240618152349.7f.nmisch@google.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a4668c99f0f85ba1b4ab120b5b6e168a6a5faef2 Modified Files -------------- src/backend/access/transam/xlog.c | 25 ++++++++++++++++++++++ src/backend/storage/ipc/sinvaladt.c | 42 +++++++++++++++++++++++++++++++++++++ src/include/storage/sinvaladt.h | 1 + 3 files changed, 68 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2024-10-25 13:51 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-10-25 13:51 pgsql: At end of recovery, reset all sinval-managed caches. Noah Misch <noah@leadboat.com> 2024-10-25 13:51 pgsql: At end of recovery, reset all sinval-managed caches. Noah Misch <noah@leadboat.com> 2024-10-25 13:51 pgsql: At end of recovery, reset all sinval-managed caches. Noah Misch <noah@leadboat.com> 2024-10-25 13:51 pgsql: At end of recovery, reset all sinval-managed caches. Noah Misch <noah@leadboat.com> 2024-10-25 13:51 pgsql: At end of recovery, reset all sinval-managed caches. Noah Misch <noah@leadboat.com> 2024-10-25 13:51 pgsql: At end of recovery, reset all sinval-managed caches. Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox