From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Set query ID for inner queries of CREATE TABLE AS and DECLARE
Date: Mon, 28 Oct 2024 00:04:15 +0000
Message-ID: <E1t5DF2-002lHQ-Dc@gemulon.postgresql.org> (raw)
Set query ID for inner queries of CREATE TABLE AS and DECLARE
Some utility statements contain queries that can be planned and
executed: CREATE TABLE AS and DECLARE CURSOR. This commit adds query ID
computation for the inner queries executed by these two utility
commands, with and without EXPLAIN. This change leads to four new
callers of JumbleQuery() and post_parse_analyze_hook() so as extensions
can decide what to do with this new data.
Previously, extensions relying on the query ID, like pg_stat_statements,
were not able to track these nested queries as the query_id was 0.
For pg_stat_statements, this commit leads to additions under !toplevel
when pg_stat_statements.track is set to "all", as shown in its
regression tests. The output of EXPLAIN for these two utilities gains a
"Query Identifier" if compute_query_id is enabled.
Author: Anthonin Bonnefoy
Reviewed-by: Michael Paquier, Jian He
Discussion: https://postgr.es/m/CAO6_XqqM6S9bQ2qd=75W+yKATwoazxSNhv5sjW06fjGAtHbTUA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6b652e6ce85a977e4ca7b8cc045cf4f3457b2d7b
Modified Files
--------------
.../pg_stat_statements/expected/level_tracking.out | 12 ++++--
src/backend/commands/createas.c | 10 +++++
src/backend/commands/explain.c | 43 ++++++++++++++--------
src/backend/commands/portalcmds.c | 10 +++++
src/backend/commands/prepare.c | 20 +++++-----
src/include/commands/explain.h | 4 +-
src/include/commands/prepare.h | 4 +-
src/test/regress/expected/explain.out | 17 +++++++++
src/test/regress/sql/explain.sql | 4 ++
9 files changed, 89 insertions(+), 35 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Set query ID for inner queries of CREATE TABLE AS and DECLARE
In-Reply-To: <E1t5DF2-002lHQ-Dc@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox