pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: doc: Add better description for rewrite functions in event trigg
Date: Tue, 29 Oct 2024 06:35:49 +0000
Message-ID: <E1t5fpW-002y53-5P@gemulon.postgresql.org> (raw)

doc: Add better description for rewrite functions in event triggers

There are two functions that can be used in event triggers to get more
details about a rewrite happening on a relation.  Both had a limited
documentation:
- pg_event_trigger_table_rewrite_reason() and
pg_event_trigger_table_rewrite_oid() were not mentioned in the main
event trigger section in the paragraph dedicated to the event
table_rewrite.
- pg_event_trigger_table_rewrite_reason() returns an integer which is a
bitmap of the reasons why a rewrite happens.  There was no explanation
about the meaning of these values, forcing the reader to look at the
code to find out that these are defined in event_trigger.h.

While on it, let's add a comment in event_trigger.h where the
AT_REWRITE_* are defined, telling to update the documentation when
these values are changed.

Backpatch down to 13 as a consequence of 1ad23335f36b, where this area
of the documentation has been heavily reworked.

Author: Greg Sabino Mullane
Discussion: https://postgr.es/m/CAKAnmmL+Z6j-C8dAx1tVrnBmZJu+BSoc68WSg3sR+CVNjBCqbw@mail.gmail.com
Backpatch-through: 13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4b7bba49e71266ec378e672a1aaa9f16823449c2

Modified Files
--------------
doc/src/sgml/event-trigger.sgml      | 5 +++++
doc/src/sgml/func.sgml               | 8 ++++++--
src/include/commands/event_trigger.h | 6 ++++++
3 files changed, 17 insertions(+), 2 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1t5fpW-002y53-5P@gemulon.postgresql.org>
Permalink:  ../E1t5fpW-002y53-5P@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1t5fpW-002y53-5P@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: doc: Add better description for rewrite functions in event trigg
  In-Reply-To: <E1t5fpW-002y53-5P@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox