pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "For inplace update, send nontransactional invalidations.
Date: Sat, 02 Nov 2024 16:08:47 +0000
Message-ID: <E1t7GgB-003cVh-V9@gemulon.postgresql.org> (raw)

Revert "For inplace update, send nontransactional invalidations."

This reverts commit 95c5acb3fc261067ab65ddc0b2dca8e162f09442 (v17) and
counterparts in each other non-master branch.  If released, that commit
would have caused a worst-in-years minor release regression, via
undetected LWLock self-deadlock.  This commit and its self-deadlock fix
warrant more bake time in the master branch.

Reported by Alexander Lakhin.

Discussion: https://postgr.es/m/10ec0bc3-5933-1189-6bb8-5dec4114558e@gmail.com

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c1099dd745b0135960895caa8892a1873ac6cbe5

Modified Files
--------------
src/backend/access/heap/heapam.c              |  43 +---
src/backend/access/transam/xact.c             |  26 +--
src/backend/catalog/index.c                   |  11 +-
src/backend/commands/event_trigger.c          |   5 +
src/backend/replication/logical/decode.c      |  26 ++-
src/backend/utils/cache/catcache.c            |   7 +-
src/backend/utils/cache/inval.c               | 304 ++++++++------------------
src/backend/utils/cache/syscache.c            |   3 +-
src/include/utils/catcache.h                  |   3 +-
src/include/utils/inval.h                     |   6 -
src/test/isolation/expected/inplace-inval.out |  10 +-
src/test/isolation/specs/inplace-inval.spec   |  12 +-
src/tools/pgindent/typedefs.list              |   1 -
13 files changed, 137 insertions(+), 320 deletions(-)

view thread (6+ messages)  latest in thread

Message-ID: <E1t7GgB-003cVh-V9@gemulon.postgresql.org>
Permalink:  ../E1t7GgB-003cVh-V9@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1t7GgB-003cVh-V9@gemulon.postgresql.org

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Revert "For inplace update, send nontransactional invalidations.
  In-Reply-To: <E1t7GgB-003cVh-V9@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox