pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Use portable diff options in pg_bsd_indent's regression test. 3+ messages / 1 participants [nested] [flat]
* pgsql: Use portable diff options in pg_bsd_indent's regression test. @ 2024-11-04 23:09 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2024-11-04 23:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use portable diff options in pg_bsd_indent's regression test. We had been using "diff -upd", which evidently works for most people, but Solaris's diff doesn't like it. (We'd not noticed because the Solaris buildfarm animals weren't running this test until they were upgraded to the latest buildfarm client script.) Change to "diff -U3" which is what pg_regress has used for ages. Per buildfarm (and off-list discussion with Noah Misch). Back-patch to v16 where this test was added. In v16, also back-patch the relevant part of 628c1d1f2 so that the test script looks about the same in all branches. Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5e08ac63a26561bddbd8d400c623f33460c51bb8 Modified Files -------------- src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Use portable diff options in pg_bsd_indent's regression test. @ 2024-11-04 23:09 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2024-11-04 23:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use portable diff options in pg_bsd_indent's regression test. We had been using "diff -upd", which evidently works for most people, but Solaris's diff doesn't like it. (We'd not noticed because the Solaris buildfarm animals weren't running this test until they were upgraded to the latest buildfarm client script.) Change to "diff -U3" which is what pg_regress has used for ages. Per buildfarm (and off-list discussion with Noah Misch). Back-patch to v16 where this test was added. In v16, also back-patch the relevant part of 628c1d1f2 so that the test script looks about the same in all branches. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/0704aed0d851abe9ec297dbd009951f0feeb12aa Modified Files -------------- src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Use portable diff options in pg_bsd_indent's regression test. @ 2024-11-04 23:09 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2024-11-04 23:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Use portable diff options in pg_bsd_indent's regression test. We had been using "diff -upd", which evidently works for most people, but Solaris's diff doesn't like it. (We'd not noticed because the Solaris buildfarm animals weren't running this test until they were upgraded to the latest buildfarm client script.) Change to "diff -U3" which is what pg_regress has used for ages. Per buildfarm (and off-list discussion with Noah Misch). Back-patch to v16 where this test was added. In v16, also back-patch the relevant part of 628c1d1f2 so that the test script looks about the same in all branches. Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/811f8d3f10a448644004954ad784bed4d51b88c7 Modified Files -------------- src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-11-04 23:09 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-11-04 23:09 pgsql: Use portable diff options in pg_bsd_indent's regression test. Tom Lane <tgl@sss.pgh.pa.us> 2024-11-04 23:09 pgsql: Use portable diff options in pg_bsd_indent's regression test. Tom Lane <tgl@sss.pgh.pa.us> 2024-11-04 23:09 pgsql: Use portable diff options in pg_bsd_indent's regression test. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox