pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use portable diff options in pg_bsd_indent's regression test.
Date: Mon, 04 Nov 2024 23:09:01 +0000
Message-ID: <E1t86Bx-000DTy-7z@gemulon.postgresql.org> (raw)

Use portable diff options in pg_bsd_indent's regression test.

We had been using "diff -upd", which evidently works for most people,
but Solaris's diff doesn't like it.  (We'd not noticed because the
Solaris buildfarm animals weren't running this test until they were
upgraded to the latest buildfarm client script.)  Change to "diff -U3"
which is what pg_regress has used for ages.

Per buildfarm (and off-list discussion with Noah Misch).

Back-patch to v16 where this test was added.  In v16,
also back-patch the relevant part of 628c1d1f2 so that
the test script looks about the same in all branches.

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5e08ac63a26561bddbd8d400c623f33460c51bb8

Modified Files
--------------
src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1t86Bx-000DTy-7z@gemulon.postgresql.org>
Permalink:  ../E1t86Bx-000DTy-7z@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1t86Bx-000DTy-7z@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Use portable diff options in pg_bsd_indent's regression test.
  In-Reply-To: <E1t86Bx-000DTy-7z@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox