pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix broken collate.icu.utf8 test in v12 branch.
2+ messages / 2 participants
[nested] [flat]
* pgsql: Fix broken collate.icu.utf8 test in v12 branch.
@ 2024-11-10 20:45 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 2+ messages in thread
From: Tom Lane @ 2024-11-10 20:45 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix broken collate.icu.utf8 test in v12 branch.
collate.icu.utf8.sql is not run by default before v13, and commits
9c4757491/46d9be5ef evidently didn't bother to test it, with
the completely predictable result that it was broken.
We didn't have enable_incremental_sort in v12, plus EXPLAIN makes
different table alias choices than later branches.
Per buildfarm member copperhead.
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0ef9ac290ff3370f345fa08091c6586fecd8354f
Modified Files
--------------
src/test/regress/expected/collate.icu.utf8.out | 64 +++++++++++++-------------
src/test/regress/sql/collate.icu.utf8.sql | 2 -
2 files changed, 31 insertions(+), 35 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: pgsql: Fix broken collate.icu.utf8 test in v12 branch.
@ 2024-11-12 07:53 Amit Langote <amitlangote09@gmail.com>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 2+ messages in thread
From: Amit Langote @ 2024-11-12 07:53 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
Hi Tom,
On Mon, Nov 11, 2024 at 5:45 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Fix broken collate.icu.utf8 test in v12 branch.
>
> collate.icu.utf8.sql is not run by default before v13, and commits
> 9c4757491/46d9be5ef evidently didn't bother to test it, with
> the completely predictable result that it was broken.
> We didn't have enable_incremental_sort in v12, plus EXPLAIN makes
> different table alias choices than later branches.
Sorry for the blunder, and thank you for taking care of it.
--
Thanks, Amit Langote
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-11-12 07:53 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-11-10 20:45 pgsql: Fix broken collate.icu.utf8 test in v12 branch. Tom Lane <tgl@sss.pgh.pa.us>
2024-11-12 07:53 ` Amit Langote <amitlangote09@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox