pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix broken collate.icu.utf8 test in v12 branch.
Date: Sun, 10 Nov 2024 20:45:42 +0000
Message-ID: <E1tAEoY-001CaM-2c@gemulon.postgresql.org> (raw)

Fix broken collate.icu.utf8 test in v12 branch.

collate.icu.utf8.sql is not run by default before v13, and commits
9c4757491/46d9be5ef evidently didn't bother to test it, with
the completely predictable result that it was broken.
We didn't have enable_incremental_sort in v12, plus EXPLAIN makes
different table alias choices than later branches.

Per buildfarm member copperhead.

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0ef9ac290ff3370f345fa08091c6586fecd8354f

Modified Files
--------------
src/test/regress/expected/collate.icu.utf8.out | 64 +++++++++++++-------------
src/test/regress/sql/collate.icu.utf8.sql      |  2 -
2 files changed, 31 insertions(+), 35 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1tAEoY-001CaM-2c@gemulon.postgresql.org>
Permalink:  ../E1tAEoY-001CaM-2c@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tAEoY-001CaM-2c@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix broken collate.icu.utf8 test in v12 branch.
  In-Reply-To: <E1tAEoY-001CaM-2c@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox