pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid bizarre meson behavior with backslashes in command argumen
Date: Mon, 11 Nov 2024 17:20:19 +0000
Message-ID: <E1tAY5L-001KkW-2I@gemulon.postgresql.org> (raw)

Avoid bizarre meson behavior with backslashes in command arguments.

meson makes the backslashes in text2macro.pl's --strip argument
into forward slashes, effectively disabling comment stripping.
That hasn't caused us issues before, but it breaks the test case
for b7e3a52a8.  We don't really need the pattern to be adjustable,
so just hard-wire it into the script instead.

Context: https://github.com/mesonbuild/meson/issues/1564
Security: CVE-2024-10979

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a34c33fd2278157de140608523598567bfb7a32f

Modified Files
--------------
src/pl/plperl/GNUmakefile   | 2 +-
src/pl/plperl/meson.build   | 2 +-
src/pl/plperl/text2macro.pl | 8 +++++---
3 files changed, 7 insertions(+), 5 deletions(-)



view thread (4+ messages)  latest in thread

Message-ID: <E1tAY5L-001KkW-2I@gemulon.postgresql.org>
Permalink:  ../E1tAY5L-001KkW-2I@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tAY5L-001KkW-2I@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Avoid bizarre meson behavior with backslashes in command argumen
  In-Reply-To: <E1tAY5L-001KkW-2I@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox