pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Avoid bizarre meson behavior with backslashes in command argumen 4+ messages / 1 participants [nested] [flat]
* pgsql: Avoid bizarre meson behavior with backslashes in command argumen @ 2024-11-11 17:20 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2024-11-11 17:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid bizarre meson behavior with backslashes in command arguments. meson makes the backslashes in text2macro.pl's --strip argument into forward slashes, effectively disabling comment stripping. That hasn't caused us issues before, but it breaks the test case for b7e3a52a8. We don't really need the pattern to be adjustable, so just hard-wire it into the script instead. Context: https://github.com/mesonbuild/meson/issues/1564 Security: CVE-2024-10979 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/a34c33fd2278157de140608523598567bfb7a32f Modified Files -------------- src/pl/plperl/GNUmakefile | 2 +- src/pl/plperl/meson.build | 2 +- src/pl/plperl/text2macro.pl | 8 +++++--- 3 files changed, 7 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Avoid bizarre meson behavior with backslashes in command argumen @ 2024-11-11 17:20 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2024-11-11 17:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid bizarre meson behavior with backslashes in command arguments. meson makes the backslashes in text2macro.pl's --strip argument into forward slashes, effectively disabling comment stripping. That hasn't caused us issues before, but it breaks the test case for b7e3a52a8. We don't really need the pattern to be adjustable, so just hard-wire it into the script instead. Context: https://github.com/mesonbuild/meson/issues/1564 Security: CVE-2024-10979 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4cd4f3b97492c1b38115d0563a2e55b136eb542a Modified Files -------------- src/pl/plperl/GNUmakefile | 2 +- src/pl/plperl/meson.build | 2 +- src/pl/plperl/text2macro.pl | 8 +++++--- 3 files changed, 7 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Avoid bizarre meson behavior with backslashes in command argumen @ 2024-11-11 17:20 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2024-11-11 17:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid bizarre meson behavior with backslashes in command arguments. meson makes the backslashes in text2macro.pl's --strip argument into forward slashes, effectively disabling comment stripping. That hasn't caused us issues before, but it breaks the test case for b7e3a52a8. We don't really need the pattern to be adjustable, so just hard-wire it into the script instead. Context: https://github.com/mesonbuild/meson/issues/1564 Security: CVE-2024-10979 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/88269df4da032bb1536d4291a13f3af4e1e599ba Modified Files -------------- src/pl/plperl/GNUmakefile | 2 +- src/pl/plperl/meson.build | 2 +- src/pl/plperl/text2macro.pl | 8 +++++--- 3 files changed, 7 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Avoid bizarre meson behavior with backslashes in command argumen @ 2024-11-11 17:27 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2024-11-11 17:27 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid bizarre meson behavior with backslashes in command arguments. Ooops, missed that v16 has another text2macro call in the MSVC scripts. Security: CVE-2024-10979 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/168579e23bdbeda1a140440c0272b335d53ad061 Modified Files -------------- src/tools/msvc/Mkvcbuild.pm | 1 - 1 file changed, 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-11-11 17:27 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-11-11 17:20 pgsql: Avoid bizarre meson behavior with backslashes in command argumen Tom Lane <tgl@sss.pgh.pa.us> 2024-11-11 17:20 pgsql: Avoid bizarre meson behavior with backslashes in command argumen Tom Lane <tgl@sss.pgh.pa.us> 2024-11-11 17:20 pgsql: Avoid bizarre meson behavior with backslashes in command argumen Tom Lane <tgl@sss.pgh.pa.us> 2024-11-11 17:27 pgsql: Avoid bizarre meson behavior with backslashes in command argumen Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox