pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix arrays comparison in CompareOpclassOptions()
10+ messages / 3 participants
[nested] [flat]
* pgsql: Fix arrays comparison in CompareOpclassOptions()
@ 2024-11-12 00:01 Alexander Korotkov <akorotkov@postgresql.org>
0 siblings, 0 replies; 10+ messages in thread
From: Alexander Korotkov @ 2024-11-12 00:01 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix arrays comparison in CompareOpclassOptions()
The current code calls array_eq() and does not provide FmgrInfo. This commit
provides initialization of FmgrInfo and uses C collation as the safe option
for text comparison because we don't know anything about the semantics of
opclass options.
Backpatch to 13, where opclass options were introduced.
Reported-by: Nicolas Maus
Discussion: https://postgr.es/m/18692-72ea398df3ec6712%40postgresql.org
Backpatch-through: 13
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/713b8546aba66be102bdd8b320c06ea3b2813fd9
Modified Files
--------------
contrib/pg_trgm/expected/pg_trgm.out | 3 +++
contrib/pg_trgm/sql/pg_trgm.sql | 4 ++++
src/backend/commands/indexcmds.c | 11 +++++++++--
3 files changed, 16 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 10+ messages in thread
* pgsql: Fix arrays comparison in CompareOpclassOptions()
@ 2024-11-12 00:03 Alexander Korotkov <akorotkov@postgresql.org>
0 siblings, 0 replies; 10+ messages in thread
From: Alexander Korotkov @ 2024-11-12 00:03 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix arrays comparison in CompareOpclassOptions()
The current code calls array_eq() and does not provide FmgrInfo. This commit
provides initialization of FmgrInfo and uses C collation as the safe option
for text comparison because we don't know anything about the semantics of
opclass options.
Backpatch to 13, where opclass options were introduced.
Reported-by: Nicolas Maus
Discussion: https://postgr.es/m/18692-72ea398df3ec6712%40postgresql.org
Backpatch-through: 13
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b242aba02666db82390fdb5a4734efde77156f61
Modified Files
--------------
contrib/pg_trgm/expected/pg_trgm.out | 3 +++
contrib/pg_trgm/sql/pg_trgm.sql | 4 ++++
src/backend/commands/indexcmds.c | 11 +++++++++--
3 files changed, 16 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 10+ messages in thread
* pgsql: Fix arrays comparison in CompareOpclassOptions()
@ 2024-11-12 00:03 Alexander Korotkov <akorotkov@postgresql.org>
0 siblings, 1 reply; 10+ messages in thread
From: Alexander Korotkov @ 2024-11-12 00:03 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix arrays comparison in CompareOpclassOptions()
The current code calls array_eq() and does not provide FmgrInfo. This commit
provides initialization of FmgrInfo and uses C collation as the safe option
for text comparison because we don't know anything about the semantics of
opclass options.
Backpatch to 13, where opclass options were introduced.
Reported-by: Nicolas Maus
Discussion: https://postgr.es/m/18692-72ea398df3ec6712%40postgresql.org
Backpatch-through: 13
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a6fa869cfa4e8f0226f22f717f5b0aa5eed60588
Modified Files
--------------
contrib/pg_trgm/expected/pg_trgm.out | 3 +++
contrib/pg_trgm/sql/pg_trgm.sql | 4 ++++
src/backend/commands/indexcmds.c | 11 +++++++++--
3 files changed, 16 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 10+ messages in thread
* pgsql: Fix arrays comparison in CompareOpclassOptions()
@ 2024-11-12 00:03 Alexander Korotkov <akorotkov@postgresql.org>
0 siblings, 0 replies; 10+ messages in thread
From: Alexander Korotkov @ 2024-11-12 00:03 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix arrays comparison in CompareOpclassOptions()
The current code calls array_eq() and does not provide FmgrInfo. This commit
provides initialization of FmgrInfo and uses C collation as the safe option
for text comparison because we don't know anything about the semantics of
opclass options.
Backpatch to 13, where opclass options were introduced.
Reported-by: Nicolas Maus
Discussion: https://postgr.es/m/18692-72ea398df3ec6712%40postgresql.org
Backpatch-through: 13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/db22b900244d3c51918acce44cbe5bb6f6507d32
Modified Files
--------------
contrib/pg_trgm/expected/pg_trgm.out | 3 +++
contrib/pg_trgm/sql/pg_trgm.sql | 4 ++++
src/backend/commands/indexcmds.c | 11 +++++++++--
3 files changed, 16 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 10+ messages in thread
* pgsql: Fix arrays comparison in CompareOpclassOptions()
@ 2024-11-12 00:03 Alexander Korotkov <akorotkov@postgresql.org>
0 siblings, 0 replies; 10+ messages in thread
From: Alexander Korotkov @ 2024-11-12 00:03 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix arrays comparison in CompareOpclassOptions()
The current code calls array_eq() and does not provide FmgrInfo. This commit
provides initialization of FmgrInfo and uses C collation as the safe option
for text comparison because we don't know anything about the semantics of
opclass options.
Backpatch to 13, where opclass options were introduced.
Reported-by: Nicolas Maus
Discussion: https://postgr.es/m/18692-72ea398df3ec6712%40postgresql.org
Backpatch-through: 13
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/247e7647f598d541775a77057df15fd32651566a
Modified Files
--------------
contrib/pg_trgm/expected/pg_trgm.out | 3 +++
contrib/pg_trgm/sql/pg_trgm.sql | 4 ++++
src/backend/commands/indexcmds.c | 11 +++++++++--
3 files changed, 16 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 10+ messages in thread
* pgsql: Fix arrays comparison in CompareOpclassOptions()
@ 2024-11-12 00:03 Alexander Korotkov <akorotkov@postgresql.org>
0 siblings, 0 replies; 10+ messages in thread
From: Alexander Korotkov @ 2024-11-12 00:03 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix arrays comparison in CompareOpclassOptions()
The current code calls array_eq() and does not provide FmgrInfo. This commit
provides initialization of FmgrInfo and uses C collation as the safe option
for text comparison because we don't know anything about the semantics of
opclass options.
Backpatch to 13, where opclass options were introduced.
Reported-by: Nicolas Maus
Discussion: https://postgr.es/m/18692-72ea398df3ec6712%40postgresql.org
Backpatch-through: 13
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5411e821386ce5c9ec794bbc9540c7c4a1acaa46
Modified Files
--------------
contrib/pg_trgm/expected/pg_trgm.out | 3 +++
contrib/pg_trgm/sql/pg_trgm.sql | 4 ++++
src/backend/commands/indexcmds.c | 11 +++++++++--
3 files changed, 16 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pgsql: Fix arrays comparison in CompareOpclassOptions()
@ 2024-11-12 00:09 Tom Lane <tgl@sss.pgh.pa.us>
parent: Alexander Korotkov <akorotkov@postgresql.org>
0 siblings, 1 reply; 10+ messages in thread
From: Tom Lane @ 2024-11-12 00:09 UTC (permalink / raw)
To: Alexander Korotkov <akorotkov@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
Alexander Korotkov <akorotkov@postgresql.org> writes:
> Fix arrays comparison in CompareOpclassOptions()
Umm ... you do realize we're still in release freeze?
https://wiki.postgresql.org/wiki/Committing_checklist#Release_freezes
Hopefully it will not make a difference, but this really should
have waited another day.
regards, tom lane
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pgsql: Fix arrays comparison in CompareOpclassOptions()
@ 2024-11-12 00:45 Alexander Korotkov <aekorotkov@gmail.com>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 10+ messages in thread
From: Alexander Korotkov @ 2024-11-12 00:45 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Alexander Korotkov <akorotkov@postgresql.org>; pgsql-committers@lists.postgresql.org
On Tue, Nov 12, 2024 at 2:09 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alexander Korotkov <akorotkov@postgresql.org> writes:
> > Fix arrays comparison in CompareOpclassOptions()
>
> Umm ... you do realize we're still in release freeze?
>
> https://wiki.postgresql.org/wiki/Committing_checklist#Release_freezes
>
> Hopefully it will not make a difference, but this really should
> have waited another day.
Oh, I specially visited the wiki page, but misread the sentence on
when the release freeze stops. Obviously yes, tags aren't pushed,
that are just stamps. And that's not February 13th.
Sorry for this. Let me know if I can do something to fix this.
------
Regards,
Alexander Korotkov
Supabase
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pgsql: Fix arrays comparison in CompareOpclassOptions()
@ 2024-11-12 01:10 Tom Lane <tgl@sss.pgh.pa.us>
parent: Alexander Korotkov <aekorotkov@gmail.com>
0 siblings, 1 reply; 10+ messages in thread
From: Tom Lane @ 2024-11-12 01:10 UTC (permalink / raw)
To: Alexander Korotkov <aekorotkov@gmail.com>; +Cc: pgsql-committers@lists.postgresql.org
Alexander Korotkov <aekorotkov@gmail.com> writes:
> On Tue, Nov 12, 2024 at 2:09 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Umm ... you do realize we're still in release freeze?
> Oh, I specially visited the wiki page, but misread the sentence on
> when the release freeze stops. Obviously yes, tags aren't pushed,
> that are just stamps. And that's not February 13th.
> Sorry for this. Let me know if I can do something to fix this.
Well, unless we need a re-wrap due to packager complaints, it
won't make a difference. If we do need a re-wrap, we'll have
to decide whether to temporarily revert this or to include it
in the re-wrapped versions. The patch looks safe enough that
probably including it would be okay ... but that was not the
plan.
I don't feel a need to make a decision about that unless it
becomes necessary, though.
regards, tom lane
^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: pgsql: Fix arrays comparison in CompareOpclassOptions()
@ 2024-11-12 01:45 Alexander Korotkov <aekorotkov@gmail.com>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 10+ messages in thread
From: Alexander Korotkov @ 2024-11-12 01:45 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
On Tue, Nov 12, 2024 at 3:10 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alexander Korotkov <aekorotkov@gmail.com> writes:
> > On Tue, Nov 12, 2024 at 2:09 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> Umm ... you do realize we're still in release freeze?
>
> > Oh, I specially visited the wiki page, but misread the sentence on
> > when the release freeze stops. Obviously yes, tags aren't pushed,
> > that are just stamps. And that's not February 13th.
> > Sorry for this. Let me know if I can do something to fix this.
>
> Well, unless we need a re-wrap due to packager complaints, it
> won't make a difference. If we do need a re-wrap, we'll have
> to decide whether to temporarily revert this or to include it
> in the re-wrapped versions. The patch looks safe enough that
> probably including it would be okay ... but that was not the
> plan.
>
> I don't feel a need to make a decision about that unless it
> becomes necessary, though.
Thank you. I'm up to revert if needed.
------
Regards,
Alexander Korotkov
Supabase
^ permalink raw reply [nested|flat] 10+ messages in thread
end of thread, other threads:[~2024-11-12 01:45 UTC | newest]
Thread overview: 10+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-11-12 00:01 pgsql: Fix arrays comparison in CompareOpclassOptions() Alexander Korotkov <akorotkov@postgresql.org>
2024-11-12 00:03 pgsql: Fix arrays comparison in CompareOpclassOptions() Alexander Korotkov <akorotkov@postgresql.org>
2024-11-12 00:03 pgsql: Fix arrays comparison in CompareOpclassOptions() Alexander Korotkov <akorotkov@postgresql.org>
2024-11-12 00:09 ` Tom Lane <tgl@sss.pgh.pa.us>
2024-11-12 00:45 ` Alexander Korotkov <aekorotkov@gmail.com>
2024-11-12 01:10 ` Tom Lane <tgl@sss.pgh.pa.us>
2024-11-12 01:45 ` Alexander Korotkov <aekorotkov@gmail.com>
2024-11-12 00:03 pgsql: Fix arrays comparison in CompareOpclassOptions() Alexander Korotkov <akorotkov@postgresql.org>
2024-11-12 00:03 pgsql: Fix arrays comparison in CompareOpclassOptions() Alexander Korotkov <akorotkov@postgresql.org>
2024-11-12 00:03 pgsql: Fix arrays comparison in CompareOpclassOptions() Alexander Korotkov <akorotkov@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox