From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Proper object locking for GRANT/REVOKE
Date: Fri, 15 Nov 2024 10:16:33 +0000
Message-ID: <E1tBtNR-001v1e-Hl@gemulon.postgresql.org> (raw)
Proper object locking for GRANT/REVOKE
Refactor objectNamesToOids() to use get_object_address() internally if
possible. Not only does this save a lot of code, it also allows us to
use the object locking provided by get_object_address() for
GRANT/REVOKE. There was previously a code comment that complained
about the lack of locking in objectNamesToOids(), which is now fixed.
The check in ExecGrant_Type_check() is obsolete because
get_object_address_type() already does the same check.
Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/bf72b82c-124d-4efa-a484-bb928e9494e4@eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d31bbfb6590e586f731345960311861d5eb4c23f
Modified Files
--------------
src/backend/catalog/aclchk.c | 157 +++++----------------
.../isolation/expected/intra-grant-inplace.out | 2 +-
2 files changed, 39 insertions(+), 120 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Proper object locking for GRANT/REVOKE
In-Reply-To: <E1tBtNR-001v1e-Hl@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox