pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix newly introduced 010_keep_recycled_wals.pl 5+ messages / 1 participants [nested] [flat]
* pgsql: Fix newly introduced 010_keep_recycled_wals.pl @ 2024-11-21 16:05 Álvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 5+ messages in thread From: Álvaro Herrera @ 2024-11-21 16:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix newly introduced 010_keep_recycled_wals.pl It failed to set the archive_command as it desired because of a syntax problem. Oversight in commit 90bcc7c2db1d. This bug doesn't cause the test to fail, because the test only checks pg_rewind's output messages, not the actual outcome (and the outcome in both cases is that the file is kept, not deleted). But in either case the message about the file being kept is there, so it's hard to get excited about doing much more. Reported-by: Antonin Houska <ah@cybertec.at> Author: Alexander Kukushkin <cyberdemn@gmail.com> Discussion: https://postgr.es/m/7822.1732167825@antos Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/b5be29ecafe1653ec53f49cbc4789b9683648bc0 Modified Files -------------- src/bin/pg_rewind/t/010_keep_recycled_wals.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix newly introduced 010_keep_recycled_wals.pl @ 2024-11-21 16:07 Álvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 5+ messages in thread From: Álvaro Herrera @ 2024-11-21 16:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix newly introduced 010_keep_recycled_wals.pl It failed to set the archive_command as it desired because of a syntax problem. Oversight in commit 90bcc7c2db1d. This bug doesn't cause the test to fail, because the test only checks pg_rewind's output messages, not the actual outcome (and the outcome in both cases is that the file is kept, not deleted). But in either case the message about the file being kept is there, so it's hard to get excited about doing much more. Reported-by: Antonin Houska <ah@cybertec.at> Author: Alexander Kukushkin <cyberdemn@gmail.com> Discussion: https://postgr.es/m/7822.1732167825@antos Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2fb3919356fb94dfef37998bf0439cc6896c93d4 Modified Files -------------- src/bin/pg_rewind/t/010_keep_recycled_wals.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix newly introduced 010_keep_recycled_wals.pl @ 2024-11-21 16:07 Álvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 5+ messages in thread From: Álvaro Herrera @ 2024-11-21 16:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix newly introduced 010_keep_recycled_wals.pl It failed to set the archive_command as it desired because of a syntax problem. Oversight in commit 90bcc7c2db1d. This bug doesn't cause the test to fail, because the test only checks pg_rewind's output messages, not the actual outcome (and the outcome in both cases is that the file is kept, not deleted). But in either case the message about the file being kept is there, so it's hard to get excited about doing much more. Reported-by: Antonin Houska <ah@cybertec.at> Author: Alexander Kukushkin <cyberdemn@gmail.com> Discussion: https://postgr.es/m/7822.1732167825@antos Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/50010c6f6c4d10e8d78d2d550bdaea461d0c83a9 Modified Files -------------- src/bin/pg_rewind/t/010_keep_recycled_wals.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix newly introduced 010_keep_recycled_wals.pl @ 2024-11-21 16:07 Álvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 5+ messages in thread From: Álvaro Herrera @ 2024-11-21 16:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix newly introduced 010_keep_recycled_wals.pl It failed to set the archive_command as it desired because of a syntax problem. Oversight in commit 90bcc7c2db1d. This bug doesn't cause the test to fail, because the test only checks pg_rewind's output messages, not the actual outcome (and the outcome in both cases is that the file is kept, not deleted). But in either case the message about the file being kept is there, so it's hard to get excited about doing much more. Reported-by: Antonin Houska <ah@cybertec.at> Author: Alexander Kukushkin <cyberdemn@gmail.com> Discussion: https://postgr.es/m/7822.1732167825@antos Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/93d8d4fe1255fa129d3447054a6b3e492de6788a Modified Files -------------- src/bin/pg_rewind/t/010_keep_recycled_wals.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix newly introduced 010_keep_recycled_wals.pl @ 2024-11-21 16:07 Álvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 5+ messages in thread From: Álvaro Herrera @ 2024-11-21 16:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix newly introduced 010_keep_recycled_wals.pl It failed to set the archive_command as it desired because of a syntax problem. Oversight in commit 90bcc7c2db1d. This bug doesn't cause the test to fail, because the test only checks pg_rewind's output messages, not the actual outcome (and the outcome in both cases is that the file is kept, not deleted). But in either case the message about the file being kept is there, so it's hard to get excited about doing much more. Reported-by: Antonin Houska <ah@cybertec.at> Author: Alexander Kukushkin <cyberdemn@gmail.com> Discussion: https://postgr.es/m/7822.1732167825@antos Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1c5fe56bc25926b9504532797c3b4fde816dfba5 Modified Files -------------- src/bin/pg_rewind/t/010_keep_recycled_wals.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2024-11-21 16:07 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-11-21 16:05 pgsql: Fix newly introduced 010_keep_recycled_wals.pl Álvaro Herrera <alvherre@alvh.no-ip.org> 2024-11-21 16:07 pgsql: Fix newly introduced 010_keep_recycled_wals.pl Álvaro Herrera <alvherre@alvh.no-ip.org> 2024-11-21 16:07 pgsql: Fix newly introduced 010_keep_recycled_wals.pl Álvaro Herrera <alvherre@alvh.no-ip.org> 2024-11-21 16:07 pgsql: Fix newly introduced 010_keep_recycled_wals.pl Álvaro Herrera <alvherre@alvh.no-ip.org> 2024-11-21 16:07 pgsql: Fix newly introduced 010_keep_recycled_wals.pl Álvaro Herrera <alvherre@alvh.no-ip.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox