pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Álvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix newly introduced 010_keep_recycled_wals.pl
Date: Thu, 21 Nov 2024 16:07:57 +0000
Message-ID: <E1tE9in-002tV2-24@gemulon.postgresql.org> (raw)

Fix newly introduced 010_keep_recycled_wals.pl

It failed to set the archive_command as it desired because of a syntax
problem.  Oversight in commit 90bcc7c2db1d.

This bug doesn't cause the test to fail, because the test only checks
pg_rewind's output messages, not the actual outcome (and the outcome in
both cases is that the file is kept, not deleted).  But in either case
the message about the file being kept is there, so it's hard to get
excited about doing much more.

Reported-by: Antonin Houska <ah@cybertec.at>
Author: Alexander Kukushkin <cyberdemn@gmail.com>
Discussion: https://postgr.es/m/7822.1732167825@antos

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/50010c6f6c4d10e8d78d2d550bdaea461d0c83a9

Modified Files
--------------
src/bin/pg_rewind/t/010_keep_recycled_wals.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1tE9in-002tV2-24@gemulon.postgresql.org>
Permalink:  ../E1tE9in-002tV2-24@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tE9in-002tV2-24@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix newly introduced 010_keep_recycled_wals.pl
  In-Reply-To: <E1tE9in-002tV2-24@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox