From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve InitShmemAccess() prototype
Date: Tue, 26 Nov 2024 07:52:03 +0000
Message-ID: <E1tFqMd-003ZyB-KR@gemulon.postgresql.org> (raw)
Improve InitShmemAccess() prototype
The code comment said, 'the argument should be declared "PGShmemHeader
*seghdr", but we use void to avoid having to include ipc.h in
shmem.h.' We can achieve the original goal with a struct forward
declaration. (ipc.h was also not the correct header file.)
Discussion: https://www.postgresql.org/message-id/flat/cnthxg2eekacrejyeonuhiaezc7vd7o2uowlsbenxqfkjwgvwj@qgzu6e...
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2a7b2d97171dd39dca7cefb91008a3c84ec003ba
Modified Files
--------------
src/backend/storage/ipc/shmem.c | 13 ++++---------
src/include/storage/shmem.h | 3 ++-
2 files changed, 6 insertions(+), 10 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve InitShmemAccess() prototype
In-Reply-To: <E1tFqMd-003ZyB-KR@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox