pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Skip SectionMemoryManager.h in cpluspluscheck.
Date: Thu, 28 Nov 2024 02:55:07 +0000
Message-ID: <E1tGUgN-003qVl-Bz@gemulon.postgresql.org> (raw)

Skip SectionMemoryManager.h in cpluspluscheck.

Commit 9044fc1d45a0 skipped SectionMemoryManager.h in headerscheck, and
by extension also cpluspluscheck, because it's C++ and would fail both
tests.  That worked in master and REL_17_STABLE due to 7b8e2ae2fd3b, but
older branches have a separate cpluspluscheck script.  We need to copy
the filtering rule into there too.

This problem was being reported by CI's CompilerWarnings task in the 15
and 16 branches, but was a victim of alert fatigue syndrome (unrelated
problems in the back-branches).

Fix 16, and back-patch to 13, as those are the live branches that have a
separate cpluspluscheck script.

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/aa663d37c068cb6bffb363f74ff6c566ecd40543

Modified Files
--------------
src/tools/pginclude/cpluspluscheck | 3 +++
1 file changed, 3 insertions(+)



view thread (4+ messages)

Message-ID: <E1tGUgN-003qVl-Bz@gemulon.postgresql.org>
Permalink:  ../E1tGUgN-003qVl-Bz@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tGUgN-003qVl-Bz@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Skip SectionMemoryManager.h in cpluspluscheck.
  In-Reply-To: <E1tGUgN-003qVl-Bz@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox