pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Skip SectionMemoryManager.h in cpluspluscheck. 4+ messages / 1 participants [nested] [flat]
* pgsql: Skip SectionMemoryManager.h in cpluspluscheck. @ 2024-11-28 02:54 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2024-11-28 02:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Skip SectionMemoryManager.h in cpluspluscheck. Commit 9044fc1d45a0 skipped SectionMemoryManager.h in headerscheck, and by extension also cpluspluscheck, because it's C++ and would fail both tests. That worked in master and REL_17_STABLE due to 7b8e2ae2fd3b, but older branches have a separate cpluspluscheck script. We need to copy the filtering rule into there too. This problem was being reported by CI's CompilerWarnings task in the 15 and 16 branches, but was a victim of alert fatigue syndrome (unrelated problems in the back-branches). Fix 16, and back-patch to 13, as those are the live branches that have a separate cpluspluscheck script. Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/06d601edc7b82ecdc24e48305f9808a3b5425752 Modified Files -------------- src/tools/pginclude/cpluspluscheck | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Skip SectionMemoryManager.h in cpluspluscheck. @ 2024-11-28 02:54 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2024-11-28 02:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Skip SectionMemoryManager.h in cpluspluscheck. Commit 9044fc1d45a0 skipped SectionMemoryManager.h in headerscheck, and by extension also cpluspluscheck, because it's C++ and would fail both tests. That worked in master and REL_17_STABLE due to 7b8e2ae2fd3b, but older branches have a separate cpluspluscheck script. We need to copy the filtering rule into there too. This problem was being reported by CI's CompilerWarnings task in the 15 and 16 branches, but was a victim of alert fatigue syndrome (unrelated problems in the back-branches). Fix 16, and back-patch to 13, as those are the live branches that have a separate cpluspluscheck script. Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b792aa989bb80ae924867e311d456c9875411828 Modified Files -------------- src/tools/pginclude/cpluspluscheck | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Skip SectionMemoryManager.h in cpluspluscheck. @ 2024-11-28 02:54 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2024-11-28 02:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Skip SectionMemoryManager.h in cpluspluscheck. Commit 9044fc1d45a0 skipped SectionMemoryManager.h in headerscheck, and by extension also cpluspluscheck, because it's C++ and would fail both tests. That worked in master and REL_17_STABLE due to 7b8e2ae2fd3b, but older branches have a separate cpluspluscheck script. We need to copy the filtering rule into there too. This problem was being reported by CI's CompilerWarnings task in the 15 and 16 branches, but was a victim of alert fatigue syndrome (unrelated problems in the back-branches). Fix 16, and back-patch to 13, as those are the live branches that have a separate cpluspluscheck script. Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4112a259021598d1bf5c39456cc6d6238baab065 Modified Files -------------- src/tools/pginclude/cpluspluscheck | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Skip SectionMemoryManager.h in cpluspluscheck. @ 2024-11-28 02:55 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2024-11-28 02:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Skip SectionMemoryManager.h in cpluspluscheck. Commit 9044fc1d45a0 skipped SectionMemoryManager.h in headerscheck, and by extension also cpluspluscheck, because it's C++ and would fail both tests. That worked in master and REL_17_STABLE due to 7b8e2ae2fd3b, but older branches have a separate cpluspluscheck script. We need to copy the filtering rule into there too. This problem was being reported by CI's CompilerWarnings task in the 15 and 16 branches, but was a victim of alert fatigue syndrome (unrelated problems in the back-branches). Fix 16, and back-patch to 13, as those are the live branches that have a separate cpluspluscheck script. Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/aa663d37c068cb6bffb363f74ff6c566ecd40543 Modified Files -------------- src/tools/pginclude/cpluspluscheck | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-11-28 02:55 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-11-28 02:54 pgsql: Skip SectionMemoryManager.h in cpluspluscheck. Thomas Munro <tmunro@postgresql.org> 2024-11-28 02:54 pgsql: Skip SectionMemoryManager.h in cpluspluscheck. Thomas Munro <tmunro@postgresql.org> 2024-11-28 02:54 pgsql: Skip SectionMemoryManager.h in cpluspluscheck. Thomas Munro <tmunro@postgresql.org> 2024-11-28 02:55 pgsql: Skip SectionMemoryManager.h in cpluspluscheck. Thomas Munro <tmunro@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox