From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: psql: Sprinkle more CppAsString2() in describe.c
Date: Thu, 28 Nov 2024 23:54:54 +0000
Message-ID: <E1tGoLV-0004dT-QB@gemulon.postgresql.org> (raw)
psql: Sprinkle more CppAsString2() in describe.c
Like 91f5a4a000ea for pg_amcheck, this makes the code more
self-documented as there is less need to look in the headers what a
hardcoded value means. This touches queries related to procedures, AMs,
functions, databases, relations, constraints, collations, types and
extended stats, pulling into psql their *_d.h headers. The queries are
written the same way as originally.
There are still a couple of hardcoded values. These cannot be included
yet as they are not exposed in headers that are safe to use in frontend
code.
Note that describe.c was including pg_am.h that should be used only in
backend code. This is updated to use pg_am_d.h.
Reviewed-by: Daniel Gustafsson, Corey Huinker
Discussion: https://postgr.es/m/Zxb2hpca-pZc6zKe@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/18954ce7f69b0a4725b1cf1845ed5fd3874e2a92
Modified Files
--------------
src/bin/psql/describe.c | 155 ++++++++++++++++++++++++++++++------------------
1 file changed, 98 insertions(+), 57 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: psql: Sprinkle more CppAsString2() in describe.c
In-Reply-To: <E1tGoLV-0004dT-QB@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox