pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Skip not SOAP-supported indexes while transforming an OR clause
Date: Fri, 29 Nov 2024 07:52:24 +0000
Message-ID: <E1tGvnb-0007ki-IW@gemulon.postgresql.org> (raw)

Skip not SOAP-supported indexes while transforming an OR clause into SAOP

There is no point in transforming OR-clauses into SAOP's if the target index
doesn't support SAOP scans anyway.  This commit adds corresponding checks
to match_orclause_to_indexcol() and group_similar_or_args().  The first check
fixes the actual bug, while the second just saves some cycles.

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/8174de69-9e1a-0827-0e81-ef97f56a5939%40gmail.com
Author: Alena Rybakina
Reviewed-by: Ranier Vilela, Alexander Korotkov, Andrei Lepikhov

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5bba0546eecb32f4ff9388815727304823940ef6

Modified Files
--------------
src/backend/optimizer/path/indxpath.c      | 11 +++++++++--
src/test/regress/expected/create_index.out | 18 ++++++++++++++++++
src/test/regress/sql/create_index.sql      |  6 ++++++
3 files changed, 33 insertions(+), 2 deletions(-)



Message-ID: <E1tGvnb-0007ki-IW@gemulon.postgresql.org>
Permalink:  ../E1tGvnb-0007ki-IW@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tGvnb-0007ki-IW@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Skip not SOAP-supported indexes while transforming an OR clause
  In-Reply-To: <E1tGvnb-0007ki-IW@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox