pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix outdated comment of scram_build_secret()
Date: Tue, 10 Dec 2024 03:55:05 +0000
Message-ID: <E1tKrKz-001yO6-2D@gemulon.postgresql.org> (raw)

Fix outdated comment of scram_build_secret()

This routine documented that "iterations" would use a default value if
set to 0 by the caller.  However, the iteration should always be set by
the caller to a value strictly more than 0, as documented by an
assertion.

Oversight in b577743000cd, that has made the iteration count of SCRAM
configurable.

Author: Matheus Alcantara
Discussion: https://postgr.es/m/ac858943-4743-44cd-b4ad-08a0c10cbbc8@gmail.com
Backpatch-through: 16

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/416d1bd66c2859b2a40d265b77299c1f1d5dfc5b

Modified Files
--------------
src/common/scram-common.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1tKrKz-001yO6-2D@gemulon.postgresql.org>
Permalink:  ../E1tKrKz-001yO6-2D@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tKrKz-001yO6-2D@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix outdated comment of scram_build_secret()
  In-Reply-To: <E1tKrKz-001yO6-2D@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox