pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Print out error position for CREATE DOMAIN
Date: Mon, 16 Dec 2024 05:52:25 +0000
Message-ID: <E1tN41o-002xD1-Tt@gemulon.postgresql.org> (raw)

Print out error position for CREATE DOMAIN

This is simply done by pushing down the ParseState available in
ProcessUtility() to DefineDomain(), giving more information about the
position of an error when running a CREATE DOMAIN query.

Most of the queries impacted by this change have been added previously
in 0172b4c9449e.

Author: Kirill Reshke, Jian He
Reviewed-by: Álvaro Herrera, Tom Lane, Michael Paquier
Discussion: https://postgr.es/m/CALdSSPhqfvKbDwqJaY=yEePi_aq61GmMpW88i6ZH7CMG_2Z4Cg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/39240bcad56dc51a7896d04a1e066efcf988b58f

Modified Files
--------------
src/backend/commands/typecmds.c                    | 58 +++++++++++++---------
src/backend/tcop/utility.c                         |  2 +-
src/include/commands/typecmds.h                    |  2 +-
src/test/regress/expected/collate.icu.utf8.out     |  2 +
src/test/regress/expected/collate.linux.utf8.out   |  2 +
src/test/regress/expected/collate.out              |  2 +
.../regress/expected/collate.windows.win1252.out   |  2 +
src/test/regress/expected/domain.out               | 26 ++++++++++
8 files changed, 70 insertions(+), 26 deletions(-)



Message-ID: <E1tN41o-002xD1-Tt@gemulon.postgresql.org>
Permalink:  ../E1tN41o-002xD1-Tt@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tN41o-002xD1-Tt@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Print out error position for CREATE DOMAIN
  In-Reply-To: <E1tN41o-002xD1-Tt@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox