From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Get rid of old version of BuildTupleHashTable().
Date: Thu, 19 Dec 2024 23:07:29 +0000
Message-ID: <E1tOPc8-000QLy-VI@gemulon.postgresql.org> (raw)
Get rid of old version of BuildTupleHashTable().
It was reasonable to preserve the old API of BuildTupleHashTable()
in the back branches, but in HEAD we should actively discourage use
of that version. There are no remaining callers in core, so just
get rid of it. Then rename BuildTupleHashTableExt() back to
BuildTupleHashTable().
While at it, fix up the miserably-poorly-maintained header comment
for BuildTupleHashTable[Ext]. It looks like more than one patch in
this area has had the opinion that updating comments is beneath them.
Discussion: https://postgr.es/m/538343.1734646986@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e0a2721f7c169b50617fed797d7336cd8f10bf77
Modified Files
--------------
src/backend/executor/execGrouping.c | 93 +++++++++++--------------------
src/backend/executor/nodeAgg.c | 28 +++++-----
src/backend/executor/nodeRecursiveunion.c | 30 +++++-----
src/backend/executor/nodeSetOp.c | 30 +++++-----
src/backend/executor/nodeSubplan.c | 58 +++++++++----------
src/include/executor/executor.h | 22 +++-----
6 files changed, 115 insertions(+), 146 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Get rid of old version of BuildTupleHashTable().
In-Reply-To: <E1tOPc8-000QLy-VI@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox