From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Introduce CompactAttribute array in TupleDesc, take 2
Date: Fri, 20 Dec 2024 09:32:15 +0000
Message-ID: <E1tOZMl-000Ut6-15@gemulon.postgresql.org> (raw)
Introduce CompactAttribute array in TupleDesc, take 2
The new compact_attrs array stores a few select fields from
FormData_pg_attribute in a more compact way, using only 16 bytes per
column instead of the 104 bytes that FormData_pg_attribute uses. Using
CompactAttribute allows performance-critical operations such as tuple
deformation to be performed without looking at the FormData_pg_attribute
element in TupleDesc which means fewer cacheline accesses.
For some workloads, tuple deformation can be the most CPU intensive part
of processing the query. Some testing with 16 columns on a table
where the first column is variable length showed around a 10% increase in
transactions per second for an OLAP type query performing aggregation on
the 16th column. However, in certain cases, the increases were much
higher, up to ~25% on one AMD Zen4 machine.
This also makes pg_attribute.attcacheoff redundant. A follow-on commit
will remove it, thus shrinking the FormData_pg_attribute struct by 4
bytes.
Author: David Rowley
Reviewed-by: Andres Freund, Victor Yegorov
Discussion: https://postgr.es/m/CAApHDvrBztXP3yx=NKNmo3xwFAFhEdyPnvrDg3=M0RhDs+4vYw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5983a4cffc31640fda6643f10146a5b72b203eaa
Modified Files
--------------
contrib/amcheck/verify_heapam.c | 4 +-
contrib/pageinspect/gistfuncs.c | 4 +-
contrib/pageinspect/heapfuncs.c | 4 +-
contrib/postgres_fdw/postgres_fdw.c | 6 +-
src/backend/access/brin/brin_inclusion.c | 8 +-
src/backend/access/brin/brin_tuple.c | 2 +-
src/backend/access/common/attmap.c | 8 +-
src/backend/access/common/heaptuple.c | 53 +++++++------
src/backend/access/common/indextuple.c | 30 ++++---
src/backend/access/common/tupdesc.c | 118 ++++++++++++++++++++++++----
src/backend/access/gin/ginbulk.c | 4 +-
src/backend/access/gin/ginget.c | 4 +-
src/backend/access/gist/gist.c | 5 +-
src/backend/access/gist/gistbuild.c | 6 +-
src/backend/access/heap/heapam.c | 8 +-
src/backend/access/heap/heapam_handler.c | 2 +-
src/backend/access/heap/heaptoast.c | 6 +-
src/backend/access/nbtree/nbtutils.c | 4 +-
src/backend/access/spgist/spgdoinsert.c | 2 +-
src/backend/access/spgist/spgutils.c | 4 +-
src/backend/access/table/toast_helper.c | 2 +-
src/backend/catalog/index.c | 2 +
src/backend/commands/copy.c | 6 +-
src/backend/commands/tablecmds.c | 4 +
src/backend/executor/execExpr.c | 4 +-
src/backend/executor/execExprInterp.c | 6 +-
src/backend/executor/execJunk.c | 2 +-
src/backend/executor/execTuples.c | 8 +-
src/backend/executor/functions.c | 2 +-
src/backend/executor/nodeMemoize.c | 8 +-
src/backend/executor/nodeModifyTable.c | 4 +-
src/backend/executor/nodeValuesscan.c | 4 +-
src/backend/executor/tstoreReceiver.c | 4 +-
src/backend/jit/llvm/llvmjit_deform.c | 4 +-
src/backend/optimizer/util/plancat.c | 4 +-
src/backend/replication/pgoutput/pgoutput.c | 2 +-
src/backend/utils/adt/expandedrecord.c | 10 +--
src/backend/utils/adt/ri_triggers.c | 2 +-
src/backend/utils/cache/relcache.c | 24 ++++--
src/include/access/htup_details.h | 4 +-
src/include/access/itup.h | 10 ++-
src/include/access/tupdesc.h | 116 +++++++++++++++++++++++++--
src/include/access/tupmacs.h | 13 +--
src/tools/pgindent/typedefs.list | 1 +
44 files changed, 374 insertions(+), 154 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Introduce CompactAttribute array in TupleDesc, take 2
In-Reply-To: <E1tOZMl-000Ut6-15@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox