pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix variable reference in comment
Date: Fri, 20 Dec 2024 17:43:26 +0000
Message-ID: <E1tOh25-000YdW-Rt@gemulon.postgresql.org> (raw)

Fix variable reference in comment

This used to say "nsubxcnt isn't decreased when subtransactions
abort", but there's no variable called nsubxcnt. Commit 8548ddc61b
changed it to "subxcnt", among other typo fixes, but that was wrong
too: the comment actually talks about txn->nsubtxns. That's the field
that's incremented but never decremented and is used for the
allocation earlier in the function.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d5a7bd5670c4a59bea506f5999101a8e40ef256c

Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)



Message-ID: <E1tOh25-000YdW-Rt@gemulon.postgresql.org>
Permalink:  ../E1tOh25-000YdW-Rt@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tOh25-000YdW-Rt@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix variable reference in comment
  In-Reply-To: <E1tOh25-000YdW-Rt@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox