pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove pgrminclude annotations
Date: Tue, 24 Dec 2024 10:59:40 +0000
Message-ID: <E1tQ2dX-0015Y0-UP@gemulon.postgresql.org> (raw)

Remove pgrminclude annotations

Per git log, the last time someone tried to do something with
pgrminclude was around 2011.  Many (not all) of the "pgrminclude
ignore" annotations are of a newer date but seem to have just been
copied around during refactorings and file moves and don't seem to
reflect an actual need anymore.

There have been some parallel experiments with include-what-you-use
(IWYU) annotations, but these don't seem to correspond very strongly
to pgrminclude annotations, so there is no value in keeping the
existing ones even for that kind of thing.

So, wipe them all away.  We can always add new ones in the future
based on actual needs.

Discussion: https://www.postgresql.org/message-id/flat/2d4dc7b2-cb2e-49b1-b8ca-ba5f7024f05b%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1eb7cb21c2a2c9091bc4cdf09d37d68559af8a7d

Modified Files
--------------
src/backend/access/brin/brin.c        | 2 +-
src/backend/access/nbtree/nbtsort.c   | 2 +-
src/backend/regex/regerror.c          | 2 +-
src/backend/utils/adt/inet_net_pton.c | 3 +--
src/bin/initdb/initdb.c               | 4 ++--
src/bin/pg_amcheck/pg_amcheck.c       | 2 +-
src/bin/scripts/common.h              | 4 ++--
src/include/common/ip.h               | 2 +-
src/include/common/relpath.h          | 6 +++---
src/include/libpq/hba.h               | 2 +-
src/include/libpq/ifaddr.h            | 2 +-
src/include/pg_trace.h                | 2 +-
src/include/snowball/header.h         | 2 +-
src/pl/plpgsql/src/pl_comp.c          | 2 +-
src/pl/tcl/pltcl.c                    | 2 +-
15 files changed, 19 insertions(+), 20 deletions(-)



Message-ID: <E1tQ2dX-0015Y0-UP@gemulon.postgresql.org>
Permalink:  ../E1tQ2dX-0015Y0-UP@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tQ2dX-0015Y0-UP@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove pgrminclude annotations
  In-Reply-To: <E1tQ2dX-0015Y0-UP@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox