pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: meson: Export all libcommon functions in Windows builds 6+ messages / 1 participants [nested] [flat]
* pgsql: meson: Export all libcommon functions in Windows builds @ 2024-12-25 16:18 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-12-25 16:18 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org meson: Export all libcommon functions in Windows builds This fixes "unresolved external symbol" errors with extensions that use functions from libcommon. This was reported with pgvector. Reported-by: Andrew Kane Author: Vladlen Popolitov Backpatch-through: 16, where Meson was introduced Discussion: https://www.postgresql.org/message-id/CAOdR5yF0krWrxycA04rgUKCgKugRvGWzzGLAhDZ9bzNv8g0Lag@mail.gmail... Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/2571c1d5cc5ed2620d601a7e12179bd951f2e202 Modified Files -------------- src/common/meson.build | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: meson: Export all libcommon functions in Windows builds @ 2024-12-25 16:18 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-12-25 16:18 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org meson: Export all libcommon functions in Windows builds This fixes "unresolved external symbol" errors with extensions that use functions from libcommon. This was reported with pgvector. Reported-by: Andrew Kane Author: Vladlen Popolitov Backpatch-through: 16, where Meson was introduced Discussion: https://www.postgresql.org/message-id/CAOdR5yF0krWrxycA04rgUKCgKugRvGWzzGLAhDZ9bzNv8g0Lag@mail.gmail... Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c80acbc6fae828fc1f88ef7fc1584bdbccb8de65 Modified Files -------------- src/common/meson.build | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: meson: Export all libcommon functions in Windows builds @ 2024-12-25 16:18 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-12-25 16:18 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org meson: Export all libcommon functions in Windows builds This fixes "unresolved external symbol" errors with extensions that use functions from libcommon. This was reported with pgvector. Reported-by: Andrew Kane Author: Vladlen Popolitov Backpatch-through: 16, where Meson was introduced Discussion: https://www.postgresql.org/message-id/CAOdR5yF0krWrxycA04rgUKCgKugRvGWzzGLAhDZ9bzNv8g0Lag@mail.gmail... Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4e0d71ff22594b50d6ee545a12072306589cc462 Modified Files -------------- src/common/meson.build | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: meson: Export all libcommon functions in Windows builds @ 2024-12-25 17:25 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-12-25 17:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org meson: Export all libcommon functions in Windows builds This fixes "unresolved external symbol" errors with extensions that use functions from libpgport that need special CFLAGS to compile. Currently, that includes the CRC-32 functions. Commit 2571c1d5cc did this for libcommon, but I missed that libpqport has the same issue. Reported-by: Tom Lane Backpatch-through: 16, where Meson was introduced Discussion: https://www.postgresql.org/message-id/CAOdR5yF0krWrxycA04rgUKCgKugRvGWzzGLAhDZ9bzNv8g0Lag@mail.gmail... Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/07f902bd760791527511be9fc47440039bc86b5c Modified Files -------------- src/port/meson.build | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: meson: Export all libcommon functions in Windows builds @ 2024-12-25 17:25 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-12-25 17:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org meson: Export all libcommon functions in Windows builds This fixes "unresolved external symbol" errors with extensions that use functions from libpgport that need special CFLAGS to compile. Currently, that includes the CRC-32 functions. Commit 2571c1d5cc did this for libcommon, but I missed that libpqport has the same issue. Reported-by: Tom Lane Backpatch-through: 16, where Meson was introduced Discussion: https://www.postgresql.org/message-id/CAOdR5yF0krWrxycA04rgUKCgKugRvGWzzGLAhDZ9bzNv8g0Lag@mail.gmail... Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d8b0c64116483c1ce9711e66700dddd709941a22 Modified Files -------------- src/port/meson.build | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: meson: Export all libcommon functions in Windows builds @ 2024-12-25 17:25 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2024-12-25 17:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org meson: Export all libcommon functions in Windows builds This fixes "unresolved external symbol" errors with extensions that use functions from libpgport that need special CFLAGS to compile. Currently, that includes the CRC-32 functions. Commit 2571c1d5cc did this for libcommon, but I missed that libpqport has the same issue. Reported-by: Tom Lane Backpatch-through: 16, where Meson was introduced Discussion: https://www.postgresql.org/message-id/CAOdR5yF0krWrxycA04rgUKCgKugRvGWzzGLAhDZ9bzNv8g0Lag@mail.gmail... Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/643efb18bf80ff179981cbd91c843cc6ae97a713 Modified Files -------------- src/port/meson.build | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2024-12-25 17:25 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-12-25 16:18 pgsql: meson: Export all libcommon functions in Windows builds Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-12-25 16:18 pgsql: meson: Export all libcommon functions in Windows builds Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-12-25 16:18 pgsql: meson: Export all libcommon functions in Windows builds Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-12-25 17:25 pgsql: meson: Export all libcommon functions in Windows builds Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-12-25 17:25 pgsql: meson: Export all libcommon functions in Windows builds Heikki Linnakangas <heikki.linnakangas@iki.fi> 2024-12-25 17:25 pgsql: meson: Export all libcommon functions in Windows builds Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox