pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: meson: Export all libcommon functions in Windows builds
Date: Wed, 25 Dec 2024 17:25:11 +0000
Message-ID: <E1tQV8A-001Isa-U6@gemulon.postgresql.org> (raw)

meson: Export all libcommon functions in Windows builds

This fixes "unresolved external symbol" errors with extensions that
use functions from libpgport that need special CFLAGS to
compile. Currently, that includes the CRC-32 functions.

Commit 2571c1d5cc did this for libcommon, but I missed that libpqport
has the same issue.

Reported-by: Tom Lane
Backpatch-through: 16, where Meson was introduced
Discussion: https://www.postgresql.org/message-id/CAOdR5yF0krWrxycA04rgUKCgKugRvGWzzGLAhDZ9bzNv8g0Lag@mail.gmail...

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/643efb18bf80ff179981cbd91c843cc6ae97a713

Modified Files
--------------
src/port/meson.build | 1 +
1 file changed, 1 insertion(+)



view thread (6+ messages)

Message-ID: <E1tQV8A-001Isa-U6@gemulon.postgresql.org>
Permalink:  ../E1tQV8A-001Isa-U6@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tQV8A-001Isa-U6@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: meson: Export all libcommon functions in Windows builds
  In-Reply-To: <E1tQV8A-001Isa-U6@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox