pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use caller's memory context for radix tree iteration state
Date: Mon, 06 Jan 2025 02:18:11 +0000
Message-ID: <E1tUch0-0004iK-Si@gemulon.postgresql.org> (raw)

Use caller's memory context for radix tree iteration state

Typically only one iterator is present at any time, so it's overkill
to devote an entire context for this. Get rid of it and use the
caller's context.

This is tidy-up work, so no backpatch in this form. However, a
hypothetical extension to v17 that tried to start iteration from
an attaching backend would result in a crash, so that'll be fixed
separately in a way that doesn't change behavior in core.

Patch by me, reported and reviewed by Masahiko Sawada

Discussion: https://postgr.es/m/CAD21AoBB2U47V=F+wQRB1bERov_of5=BOZGaybjaV8FLQyqG3Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/960013f2a1f9e51aad85c91aceeb442508be6032

Modified Files
--------------
src/include/lib/radixtree.h | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)



Message-ID: <E1tUch0-0004iK-Si@gemulon.postgresql.org>
Permalink:  ../E1tUch0-0004iK-Si@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tUch0-0004iK-Si@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: john.naylor@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Use caller's memory context for radix tree iteration state
  In-Reply-To: <E1tUch0-0004iK-Si@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox