From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve nbtree unsatisfiable RowCompare detection.
Date: Tue, 07 Jan 2025 15:39:07 +0000
Message-ID: <E1tVBff-000LNp-II@gemulon.postgresql.org> (raw)
Improve nbtree unsatisfiable RowCompare detection.
Move nbtree's detection of RowCompare quals that are unsatisfiable due
to having a NULL in their first row element: rather than detecting these
cases at the point where _bt_first builds its insertion scan key, do so
earlier, during preprocessing proper. This brings the RowCompare case
in line every other case involving an unsatisfiable-due-to-NULL qual.
nbtree now consistently detects such unsatisfiable quals -- even when
they happen to involve a key that isn't examined by _bt_first at all.
Affected cases thereby avoid useless full index scans that cannot
possibly return any matching rows.
Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: Matthias van de Meent <boekewurm+postgres@gmail.com>
Discussion: https://postgr.es/m/CAH2-WzmySVXst2hFrOATC-zw1Byg1XC-jYUS314=mzuqsNwk+Q@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ec986020decff322723cf7b3a2696803d082ad17
Modified Files
--------------
src/backend/access/nbtree/nbtsearch.c | 26 +++---
src/backend/access/nbtree/nbtutils.c | 14 +++-
src/test/regress/expected/btree_index.out | 127 +++++++++++++++++++++++++++++
src/test/regress/expected/create_index.out | 13 +++
src/test/regress/sql/btree_index.sql | 79 ++++++++++++++++++
src/test/regress/sql/create_index.sql | 5 ++
6 files changed, 248 insertions(+), 16 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: pg@bowt.ie, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve nbtree unsatisfiable RowCompare detection.
In-Reply-To: <E1tVBff-000LNp-II@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox