pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Álvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove unnecessary code to handle CONSTR_NOTNULL
Date: Tue, 07 Jan 2025 15:51:14 +0000
Message-ID: <E1tVBrO-000LTp-1i@gemulon.postgresql.org> (raw)

Remove unnecessary code to handle CONSTR_NOTNULL

Commit 14e87ffa5c54 needlessly added support for CONSTR_NOTNULL entries
to StoreConstraints.  It's dead code, so remove it.

To make the situation regarding constraint creation clearer, change
comments in heap_create_with_catalog, StoreConstraints, MergeAttributes
to explain which types of constraint are used on each.

Author: 何建 (Jian He) <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxFxzqrCiUNfjJ0tQU+=nKQkQCGtGzUBude=SMOwj5VNjQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5b291d1c9c09d75982c3270bfa61d4e822087b6a

Modified Files
--------------
src/backend/catalog/heap.c       | 13 +++----------
src/backend/commands/tablecmds.c | 15 ++++++++-------
2 files changed, 11 insertions(+), 17 deletions(-)



Message-ID: <E1tVBrO-000LTp-1i@gemulon.postgresql.org>
Permalink:  ../E1tVBrO-000LTp-1i@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tVBrO-000LTp-1i@gemulon.postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove unnecessary code to handle CONSTR_NOTNULL
  In-Reply-To: <E1tVBrO-000LTp-1i@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox