pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Restore smgrtruncate() prototype in back-branches. 5+ messages / 1 participants [nested] [flat]
* pgsql: Restore smgrtruncate() prototype in back-branches. @ 2025-01-07 21:55 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Thomas Munro @ 2025-01-07 21:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Restore smgrtruncate() prototype in back-branches. It's possible that external code is calling smgrtruncate(). Any external callers might like to consider the recent changes to RelationTruncate(), but commit 38c579b0 should not have changed the function prototype in the back-branches, per ABI stability policy. Restore smgrtruncate()'s traditional argument list in the back-branches, but make it a wrapper for a new function smgrtruncate2(). The three callers in core can use smgrtruncate2() directly. In master (18-to-be), smgrtruncate2() is effectively renamed to smgrtruncate(), so this wart is cleaned up. Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/CA%2BhUKG%2BThae6x6%2BjmQiuALQBT2Ae1ChjMh1%3DkMvJ8y_SBJZrvA%40mail.gmail.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/66aaabe7a18f2bc5d22cd832ad612ba5bab18d7b Modified Files -------------- contrib/pg_visibility/pg_visibility.c | 2 +- src/backend/catalog/storage.c | 4 ++-- src/backend/storage/smgr/smgr.c | 24 ++++++++++++++++++++++-- src/include/storage/smgr.h | 4 +++- 4 files changed, 28 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Restore smgrtruncate() prototype in back-branches. @ 2025-01-07 21:56 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Thomas Munro @ 2025-01-07 21:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Restore smgrtruncate() prototype in back-branches. It's possible that external code is calling smgrtruncate(). Any external callers might like to consider the recent changes to RelationTruncate(), but commit 38c579b0 should not have changed the function prototype in the back-branches, per ABI stability policy. Restore smgrtruncate()'s traditional argument list in the back-branches, but make it a wrapper for a new function smgrtruncate2(). The three callers in core can use smgrtruncate2() directly. In master (18-to-be), smgrtruncate2() is effectively renamed to smgrtruncate(), so this wart is cleaned up. Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/CA%2BhUKG%2BThae6x6%2BjmQiuALQBT2Ae1ChjMh1%3DkMvJ8y_SBJZrvA%40mail.gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c957d7444fccb3c61b5f00908ef91aba012c683b Modified Files -------------- contrib/pg_visibility/pg_visibility.c | 2 +- src/backend/catalog/storage.c | 4 ++-- src/backend/storage/smgr/smgr.c | 24 ++++++++++++++++++++++-- src/include/storage/smgr.h | 4 +++- 4 files changed, 28 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Restore smgrtruncate() prototype in back-branches. @ 2025-01-07 21:56 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Thomas Munro @ 2025-01-07 21:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Restore smgrtruncate() prototype in back-branches. It's possible that external code is calling smgrtruncate(). Any external callers might like to consider the recent changes to RelationTruncate(), but commit 38c579b0 should not have changed the function prototype in the back-branches, per ABI stability policy. Restore smgrtruncate()'s traditional argument list in the back-branches, but make it a wrapper for a new function smgrtruncate2(). The three callers in core can use smgrtruncate2() directly. In master (18-to-be), smgrtruncate2() is effectively renamed to smgrtruncate(), so this wart is cleaned up. Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/CA%2BhUKG%2BThae6x6%2BjmQiuALQBT2Ae1ChjMh1%3DkMvJ8y_SBJZrvA%40mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3181befdca7142d3563b4399e51e5c60da54def0 Modified Files -------------- contrib/pg_visibility/pg_visibility.c | 2 +- src/backend/catalog/storage.c | 4 ++-- src/backend/storage/smgr/smgr.c | 24 ++++++++++++++++++++++-- src/include/storage/smgr.h | 4 +++- 4 files changed, 28 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Restore smgrtruncate() prototype in back-branches. @ 2025-01-07 21:56 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Thomas Munro @ 2025-01-07 21:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Restore smgrtruncate() prototype in back-branches. It's possible that external code is calling smgrtruncate(). Any external callers might like to consider the recent changes to RelationTruncate(), but commit 38c579b0 should not have changed the function prototype in the back-branches, per ABI stability policy. Restore smgrtruncate()'s traditional argument list in the back-branches, but make it a wrapper for a new function smgrtruncate2(). The three callers in core can use smgrtruncate2() directly. In master (18-to-be), smgrtruncate2() is effectively renamed to smgrtruncate(), so this wart is cleaned up. Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/CA%2BhUKG%2BThae6x6%2BjmQiuALQBT2Ae1ChjMh1%3DkMvJ8y_SBJZrvA%40mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f154f028d856bf5ad6ec419d7947865c172d14ae Modified Files -------------- contrib/pg_visibility/pg_visibility.c | 2 +- src/backend/catalog/storage.c | 4 ++-- src/backend/storage/smgr/smgr.c | 24 ++++++++++++++++++++++-- src/include/storage/smgr.h | 4 +++- 4 files changed, 28 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Restore smgrtruncate() prototype in back-branches. @ 2025-01-07 21:56 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Thomas Munro @ 2025-01-07 21:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Restore smgrtruncate() prototype in back-branches. It's possible that external code is calling smgrtruncate(). Any external callers might like to consider the recent changes to RelationTruncate(), but commit 38c579b0 should not have changed the function prototype in the back-branches, per ABI stability policy. Restore smgrtruncate()'s traditional argument list in the back-branches, but make it a wrapper for a new function smgrtruncate2(). The three callers in core can use smgrtruncate2() directly. In master (18-to-be), smgrtruncate2() is effectively renamed to smgrtruncate(), so this wart is cleaned up. Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/CA%2BhUKG%2BThae6x6%2BjmQiuALQBT2Ae1ChjMh1%3DkMvJ8y_SBJZrvA%40mail.gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a1d17a8947311cbee9100ceb2b1c43a8770d6d32 Modified Files -------------- contrib/pg_visibility/pg_visibility.c | 2 +- src/backend/catalog/storage.c | 4 ++-- src/backend/storage/smgr/smgr.c | 24 ++++++++++++++++++++++-- src/include/storage/smgr.h | 4 +++- 4 files changed, 28 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2025-01-07 21:56 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-01-07 21:55 pgsql: Restore smgrtruncate() prototype in back-branches. Thomas Munro <tmunro@postgresql.org> 2025-01-07 21:56 pgsql: Restore smgrtruncate() prototype in back-branches. Thomas Munro <tmunro@postgresql.org> 2025-01-07 21:56 pgsql: Restore smgrtruncate() prototype in back-branches. Thomas Munro <tmunro@postgresql.org> 2025-01-07 21:56 pgsql: Restore smgrtruncate() prototype in back-branches. Thomas Munro <tmunro@postgresql.org> 2025-01-07 21:56 pgsql: Restore smgrtruncate() prototype in back-branches. Thomas Munro <tmunro@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox