From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Restore smgrtruncate() prototype in back-branches.
Date: Tue, 07 Jan 2025 21:56:03 +0000
Message-ID: <E1tVHYQ-000OxT-RT@gemulon.postgresql.org> (raw)
Restore smgrtruncate() prototype in back-branches.
It's possible that external code is calling smgrtruncate(). Any
external callers might like to consider the recent changes to
RelationTruncate(), but commit 38c579b0 should not have changed the
function prototype in the back-branches, per ABI stability policy.
Restore smgrtruncate()'s traditional argument list in the back-branches,
but make it a wrapper for a new function smgrtruncate2(). The three
callers in core can use smgrtruncate2() directly. In master (18-to-be),
smgrtruncate2() is effectively renamed to smgrtruncate(), so this wart
is cleaned up.
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/CA%2BhUKG%2BThae6x6%2BjmQiuALQBT2Ae1ChjMh1%3DkMvJ8y_SBJZrvA%40mail.gmail.com
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c957d7444fccb3c61b5f00908ef91aba012c683b
Modified Files
--------------
contrib/pg_visibility/pg_visibility.c | 2 +-
src/backend/catalog/storage.c | 4 ++--
src/backend/storage/smgr/smgr.c | 24 ++++++++++++++++++++++--
src/include/storage/smgr.h | 4 +++-
4 files changed, 28 insertions(+), 6 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Restore smgrtruncate() prototype in back-branches.
In-Reply-To: <E1tVHYQ-000OxT-RT@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox