From: Álvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Simplify signature of RewriteTable
Date: Thu, 09 Jan 2025 13:17:49 +0000
Message-ID: <E1tVsQ1-000fCF-OC@gemulon.postgresql.org> (raw)
Simplify signature of RewriteTable
This function doesn't need the lockmode to be passed: it was being used
to lock the new heap, but that's bogus, because the only caller has
already obtained the appropriate lock on the new heap (which is
unimportant anyway, because the relation's creation is not yet committed
and so no other session can see it).
Noticed while reviewed Antonin Houska's patch to add VACUUM FULL
CONCURRENTLY.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ebd8fc7e47fdad6adb68aad341d95c541d7325c3
Modified Files
--------------
src/backend/commands/tablecmds.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Simplify signature of RewriteTable
In-Reply-To: <E1tVsQ1-000fCF-OC@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox