pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix an ALTER GROUP ... DROP USER error message.
Date: Thu, 09 Jan 2025 23:13:32 +0000
Message-ID: <E1tW1iW-000jfG-3C@gemulon.postgresql.org> (raw)

Fix an ALTER GROUP ... DROP USER error message.

This error message stated the privileges required to add a member
to a group even if the user was trying to drop a member:

        postgres=> alter group a drop user b;
        ERROR:  permission denied to alter role
        DETAIL:  Only roles with the ADMIN option on role "a" may add members.

Since the required privileges for both operations are the same, we
can fix this by modifying the message to mention both adding and
dropping members:

        postgres=> alter group a drop user b;
        ERROR:  permission denied to alter role
        DETAIL:  Only roles with the ADMIN option on role "a" may add or drop members.

Author: ChangAo Chen
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/tencent_FAA0D00E3514AAF0BBB6322542A6094FEF05%40qq.com
Backpatch-through: 16

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0b5927dfac26a620b0bed53d8955e68a134db452

Modified Files
--------------
src/backend/commands/user.c              | 4 ++--
src/test/regress/expected/privileges.out | 7 +++++++
src/test/regress/sql/privileges.sql      | 3 +++
3 files changed, 12 insertions(+), 2 deletions(-)



view thread (3+ messages)

Message-ID: <E1tW1iW-000jfG-3C@gemulon.postgresql.org>
Permalink:  ../E1tW1iW-000jfG-3C@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tW1iW-000jfG-3C@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix an ALTER GROUP ... DROP USER error message.
  In-Reply-To: <E1tW1iW-000jfG-3C@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox