From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix catcache invalidation of a list entry that's being built
Date: Tue, 14 Jan 2025 13:13:05 +0000
Message-ID: <E1tXgjB-001VbX-IQ@gemulon.postgresql.org> (raw)
Fix catcache invalidation of a list entry that's being built
If a new catalog tuple is inserted that belongs to a catcache list
entry, and cache invalidation happens while the list entry is being
built, the list entry might miss the newly inserted tuple.
To fix, change the way we detect concurrent invalidations while a
catcache entry is being built. Keep a stack of entries that are being
built, and apply cache invalidation to those entries in addition to
the real catcache entries. This is similar to the in-progress list in
relcache.c.
Back-patch to all supported versions.
Reviewed-by: Noah Misch
Discussion: https://www.postgresql.org/message-id/2234dc98-06fe-42ed-b5db-ac17384dc880@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/af8cd1639ab298ba8fae62cd9583f1c10a5068e1
Modified Files
--------------
src/backend/utils/cache/catcache.c | 232 +++++++++++++--------
src/backend/utils/cache/inval.c | 2 +-
src/include/utils/catcache.h | 1 +
src/test/modules/test_misc/meson.build | 1 +
src/test/modules/test_misc/t/007_catcache_inval.pl | 98 +++++++++
src/tools/pgindent/typedefs.list | 1 +
6 files changed, 252 insertions(+), 83 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix catcache invalidation of a list entry that's being built
In-Reply-To: <E1tXgjB-001VbX-IQ@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox