From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rename RowCompareType to CompareType
Date: Wed, 15 Jan 2025 07:49:48 +0000
Message-ID: <E1tXy9s-001gWb-3L@gemulon.postgresql.org> (raw)
Rename RowCompareType to CompareType
RowCompareType served as a way to describe the fundamental meaning of
an operator, notionally independent of an operator class (although so
far this was only really supported for btrees). Its original purpose
was for use inside RowCompareExpr, and it has also found some small
use outside, such as for get_op_btree_interpretation().
We want to expand this now, as a more general way to describe operator
semantics for other index access methods, including gist (to improve
GistTranslateStratnum()) and others not written yet. To avoid future
confusion, we rename the type to CompareType and the symbols from
ROWCOMPARE_XXX to COMPARE_XXX to reflect their more general purpose.
Reviewed-by: Mark Dilger <mark.dilger@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/flat/E72EAA49-354D-4C2E-8EB9-255197F55330@enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6339f6468e8217f556e38482626250dc72d7cd00
Modified Files
--------------
src/backend/executor/execExpr.c | 2 +-
src/backend/executor/execExprInterp.c | 12 +++++-----
src/backend/executor/nodeIndexscan.c | 4 ++--
src/backend/jit/llvm/llvmjit_expr.c | 12 +++++-----
src/backend/optimizer/path/indxpath.c | 2 +-
src/backend/optimizer/util/predtest.c | 2 +-
src/backend/parser/parse_expr.c | 12 +++++-----
src/backend/utils/cache/lsyscache.c | 6 ++---
src/include/executor/execExpr.h | 2 +-
src/include/nodes/primnodes.h | 41 +++++++++++++++++++++++------------
src/tools/pgindent/typedefs.list | 2 +-
11 files changed, 55 insertions(+), 42 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rename RowCompareType to CompareType
In-Reply-To: <E1tXy9s-001gWb-3L@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox