pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Change gist stratnum function to use CompareType
Date: Wed, 15 Jan 2025 10:41:40 +0000
Message-ID: <E1tY0qC-001hzx-Gi@gemulon.postgresql.org> (raw)

Change gist stratnum function to use CompareType

This changes commit 7406ab623fe in that the gist strategy number
mapping support function is changed to use the CompareType enum as
input, instead of the "well-known" RT*StrategyNumber strategy numbers.

This is a bit cleaner, since you are not dealing with two sets of
strategy numbers.  Also, this will enable us to subsume this system
into a more general system of using CompareType to define operator
semantics across index methods.

Discussion: https://www.postgresql.org/message-id/flat/E72EAA49-354D-4C2E-8EB9-255197F55330@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/630f9a43cece93cb4a5c243b30e34abce6a89514

Modified Files
--------------
contrib/btree_gist/btree_gist--1.7--1.8.sql  | 54 ++++++++++++++--------------
contrib/btree_gist/btree_gist.c              | 15 ++++----
contrib/btree_gist/expected/stratnum.out     |  4 +--
contrib/btree_gist/sql/stratnum.sql          |  4 +--
doc/src/sgml/gist.sgml                       | 24 ++++++-------
doc/src/sgml/xindex.sgml                     |  2 +-
src/backend/access/gist/gistutil.c           | 35 +++++++++++++-----
src/backend/access/gist/gistvalidate.c       |  2 +-
src/backend/catalog/pg_constraint.c          | 20 +++++------
src/backend/commands/indexcmds.c             | 50 +++++++++++++-------------
src/backend/commands/tablecmds.c             | 10 +++---
src/backend/executor/execReplication.c       |  2 +-
src/include/access/gist.h                    |  3 +-
src/include/catalog/pg_amproc.dat            | 12 +++----
src/include/catalog/pg_proc.dat              |  6 ++--
src/include/commands/defrem.h                |  4 +--
src/include/nodes/primnodes.h                |  4 ++-
src/test/regress/expected/misc_functions.out | 16 ++++-----
src/test/regress/sql/misc_functions.sql      |  4 +--
19 files changed, 145 insertions(+), 126 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1tY0qC-001hzx-Gi@gemulon.postgresql.org>
Permalink:  ../E1tY0qC-001hzx-Gi@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tY0qC-001hzx-Gi@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Change gist stratnum function to use CompareType
  In-Reply-To: <E1tY0qC-001hzx-Gi@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox