pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Drop warning-free support for Flex 2.5.35
Date: Wed, 15 Jan 2025 14:40:55 +0000
Message-ID: <E1tY4Zj-001jp9-1h@gemulon.postgresql.org> (raw)

Drop warning-free support for Flex 2.5.35

This removes all the various workarounds for avoiding compiler
warnings with Flex 2.5.35.  Several recent patches have added
additional warnings that would either need to be fixed along the lines
of the existing workarounds, or we decide to no longer care about
this, which we do here.

Flex 2.5.35 is extremely outdated, and you can't even download it
anymore from any of the Flex project sites, so it's nearly impossible
to support.

After this, using Flex 2.5.35 will still work, but the generated code
will produce numerous compiler warnings.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/1a204ccd-7ae6-478c-a431-407b5c48ccc6@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6fdd5d9563439285df200f7282f0ca68152ef72d

Modified Files
--------------
src/Makefile.global.in         |  1 -
src/backend/parser/Makefile    |  1 -
src/backend/parser/meson.build |  2 +-
src/backend/parser/scan.l      |  9 ------
src/bin/pgbench/exprscan.l     |  9 ------
src/bin/psql/Makefile          |  1 -
src/bin/psql/meson.build       |  2 +-
src/bin/psql/psqlscanslash.l   |  9 ------
src/fe_utils/Makefile          |  1 -
src/fe_utils/meson.build       |  2 +-
src/fe_utils/psqlscan.l        |  9 ------
src/tools/fix-old-flex-code.pl | 66 ------------------------------------------
src/tools/pgflex               | 13 ---------
13 files changed, 3 insertions(+), 122 deletions(-)



Message-ID: <E1tY4Zj-001jp9-1h@gemulon.postgresql.org>
Permalink:  ../E1tY4Zj-001jp9-1h@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tY4Zj-001jp9-1h@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Drop warning-free support for Flex 2.5.35
  In-Reply-To: <E1tY4Zj-001jp9-1h@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox