pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster 6+ messages / 1 participants [nested] [flat]
* pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster @ 2025-01-16 00:26 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2025-01-16 00:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Move routines to manipulate WAL into PostgreSQL::Test::Cluster These facilities were originally in the recovery TAP test 039_end_of_wal.pl. A follow-up bug fix with a TAP test doing similar WAL manipulations requires them, and all these had better not be duplicated due to their complexity. The routine names are tweaked to use "wal" more consistently, similarly to the existing "advance_wal". In v14 and v13, the new routines are moved to PostgresNode.pm. 039_end_of_wal.pl is updated to use the refactored routines, without changing its coverage. Reviewed-by: Alexander Kukushkin Discussion: https://postgr.es/m/CAFh8B=mozC+e1wGJq0H=0O65goZju+6ab5AU7DEWCSUA2OtwDg@mail.gmail.com Backpatch-through: 13 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/32a18cc0a73d8deb1e81d6ef8a9d5a6f300ed397 Modified Files -------------- src/test/perl/PostgreSQL/Test/Cluster.pm | 148 ++++++++++++++++++ src/test/recovery/t/039_end_of_wal.pl | 257 ++++++++----------------------- 2 files changed, 214 insertions(+), 191 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster @ 2025-01-16 00:26 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2025-01-16 00:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Move routines to manipulate WAL into PostgreSQL::Test::Cluster These facilities were originally in the recovery TAP test 039_end_of_wal.pl. A follow-up bug fix with a TAP test doing similar WAL manipulations requires them, and all these had better not be duplicated due to their complexity. The routine names are tweaked to use "wal" more consistently, similarly to the existing "advance_wal". In v14 and v13, the new routines are moved to PostgresNode.pm. 039_end_of_wal.pl is updated to use the refactored routines, without changing its coverage. Reviewed-by: Alexander Kukushkin Discussion: https://postgr.es/m/CAFh8B=mozC+e1wGJq0H=0O65goZju+6ab5AU7DEWCSUA2OtwDg@mail.gmail.com Backpatch-through: 13 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/149ed87e22ce70608cc584f2f54c2f12d3a96680 Modified Files -------------- src/test/perl/PostgreSQL/Test/Cluster.pm | 148 ++++++++++++++++++ src/test/recovery/t/039_end_of_wal.pl | 257 ++++++++----------------------- 2 files changed, 214 insertions(+), 191 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster @ 2025-01-16 00:26 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2025-01-16 00:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Move routines to manipulate WAL into PostgreSQL::Test::Cluster These facilities were originally in the recovery TAP test 039_end_of_wal.pl. A follow-up bug fix with a TAP test doing similar WAL manipulations requires them, and all these had better not be duplicated due to their complexity. The routine names are tweaked to use "wal" more consistently, similarly to the existing "advance_wal". In v14 and v13, the new routines are moved to PostgresNode.pm. 039_end_of_wal.pl is updated to use the refactored routines, without changing its coverage. Reviewed-by: Alexander Kukushkin Discussion: https://postgr.es/m/CAFh8B=mozC+e1wGJq0H=0O65goZju+6ab5AU7DEWCSUA2OtwDg@mail.gmail.com Backpatch-through: 13 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9420f9bb61e6c244107a01b96e9ea07231b52ba7 Modified Files -------------- src/test/perl/PostgreSQL/Test/Cluster.pm | 148 ++++++++++++++++++ src/test/recovery/t/039_end_of_wal.pl | 257 ++++++++----------------------- 2 files changed, 214 insertions(+), 191 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster @ 2025-01-16 00:26 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2025-01-16 00:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Move routines to manipulate WAL into PostgreSQL::Test::Cluster These facilities were originally in the recovery TAP test 039_end_of_wal.pl. A follow-up bug fix with a TAP test doing similar WAL manipulations requires them, and all these had better not be duplicated due to their complexity. The routine names are tweaked to use "wal" more consistently, similarly to the existing "advance_wal". In v14 and v13, the new routines are moved to PostgresNode.pm. 039_end_of_wal.pl is updated to use the refactored routines, without changing its coverage. Reviewed-by: Alexander Kukushkin Discussion: https://postgr.es/m/CAFh8B=mozC+e1wGJq0H=0O65goZju+6ab5AU7DEWCSUA2OtwDg@mail.gmail.com Backpatch-through: 13 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e5d113057d5fb8e6ecd39521784d48d4966f6a53 Modified Files -------------- src/test/perl/PostgreSQL/Test/Cluster.pm | 148 ++++++++++++++++++ src/test/recovery/t/039_end_of_wal.pl | 257 ++++++++----------------------- 2 files changed, 214 insertions(+), 191 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster @ 2025-01-16 00:26 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2025-01-16 00:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Move routines to manipulate WAL into PostgreSQL::Test::Cluster These facilities were originally in the recovery TAP test 039_end_of_wal.pl. A follow-up bug fix with a TAP test doing similar WAL manipulations requires them, and all these had better not be duplicated due to their complexity. The routine names are tweaked to use "wal" more consistently, similarly to the existing "advance_wal". In v14 and v13, the new routines are moved to PostgresNode.pm. 039_end_of_wal.pl is updated to use the refactored routines, without changing its coverage. Reviewed-by: Alexander Kukushkin Discussion: https://postgr.es/m/CAFh8B=mozC+e1wGJq0H=0O65goZju+6ab5AU7DEWCSUA2OtwDg@mail.gmail.com Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/50406b15540cee90d3038229829b417cbd755bd7 Modified Files -------------- src/test/perl/PostgresNode.pm | 148 +++++++++++++++++++ src/test/recovery/t/039_end_of_wal.pl | 263 +++++++++------------------------- 2 files changed, 214 insertions(+), 197 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster @ 2025-01-16 00:26 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2025-01-16 00:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Move routines to manipulate WAL into PostgreSQL::Test::Cluster These facilities were originally in the recovery TAP test 039_end_of_wal.pl. A follow-up bug fix with a TAP test doing similar WAL manipulations requires them, and all these had better not be duplicated due to their complexity. The routine names are tweaked to use "wal" more consistently, similarly to the existing "advance_wal". In v14 and v13, the new routines are moved to PostgresNode.pm. 039_end_of_wal.pl is updated to use the refactored routines, without changing its coverage. Reviewed-by: Alexander Kukushkin Discussion: https://postgr.es/m/CAFh8B=mozC+e1wGJq0H=0O65goZju+6ab5AU7DEWCSUA2OtwDg@mail.gmail.com Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c9e50ce2a04483c353bc4def378334cce9443a93 Modified Files -------------- src/test/perl/PostgresNode.pm | 148 +++++++++++++++++++ src/test/recovery/t/039_end_of_wal.pl | 263 +++++++++------------------------- 2 files changed, 214 insertions(+), 197 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-01-16 00:26 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-01-16 00:26 pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster Michael Paquier <michael@paquier.xyz> 2025-01-16 00:26 pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster Michael Paquier <michael@paquier.xyz> 2025-01-16 00:26 pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster Michael Paquier <michael@paquier.xyz> 2025-01-16 00:26 pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster Michael Paquier <michael@paquier.xyz> 2025-01-16 00:26 pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster Michael Paquier <michael@paquier.xyz> 2025-01-16 00:26 pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox