From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster
Date: Thu, 16 Jan 2025 00:26:58 +0000
Message-ID: <E1tYDir-001onB-Pe@gemulon.postgresql.org> (raw)
Move routines to manipulate WAL into PostgreSQL::Test::Cluster
These facilities were originally in the recovery TAP test
039_end_of_wal.pl. A follow-up bug fix with a TAP test doing similar
WAL manipulations requires them, and all these had better not be
duplicated due to their complexity. The routine names are tweaked to
use "wal" more consistently, similarly to the existing "advance_wal".
In v14 and v13, the new routines are moved to PostgresNode.pm.
039_end_of_wal.pl is updated to use the refactored routines, without
changing its coverage.
Reviewed-by: Alexander Kukushkin
Discussion: https://postgr.es/m/CAFh8B=mozC+e1wGJq0H=0O65goZju+6ab5AU7DEWCSUA2OtwDg@mail.gmail.com
Backpatch-through: 13
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/9420f9bb61e6c244107a01b96e9ea07231b52ba7
Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 148 ++++++++++++++++++
src/test/recovery/t/039_end_of_wal.pl | 257 ++++++++-----------------------
2 files changed, 214 insertions(+), 191 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move routines to manipulate WAL into PostgreSQL::Test::Cluster
In-Reply-To: <E1tYDir-001onB-Pe@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox