pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Álvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Split ATExecValidateConstraint into reusable pieces
Date: Thu, 16 Jan 2025 15:46:38 +0000
Message-ID: <E1tYS4s-001wFl-FP@gemulon.postgresql.org> (raw)

Split ATExecValidateConstraint into reusable pieces

With this, we have separate functions to add validation requests to
ALTER TABLE's phase 3 queue for check and foreign key constraints, which
allows reusing them in future commits -- particularly this will allow us
to perform validation of invalid foreign key constraints in partitioned
tables.

We could have let the check constraint code alone since we don't need to
reuse that for anything at this point, but it seems cleaner and more
consistent to do both at the same time.

Author: Amul Sul <sulamul@gmail.com>
Discussion: https://postgr.es/m/CAAJ_b96Bp=-ZwihPPtuaNX=SrZ0U6ZsXD3+fgARO0JuKa8v2jQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/86374c9a0e304520044ab8b2cb84849c7db4a9fa

Modified Files
--------------
src/backend/commands/tablecmds.c | 271 ++++++++++++++++++++++++---------------
1 file changed, 165 insertions(+), 106 deletions(-)



Message-ID: <E1tYS4s-001wFl-FP@gemulon.postgresql.org>
Permalink:  ../E1tYS4s-001wFl-FP@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tYS4s-001wFl-FP@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Split ATExecValidateConstraint into reusable pieces
  In-Reply-To: <E1tYS4s-001wFl-FP@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox