pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add pg_nodiscard decorations to base64 functions
Date: Fri, 17 Jan 2025 07:29:09 +0000
Message-ID: <E1tYgmz-0022Qf-4r@gemulon.postgresql.org> (raw)

Add pg_nodiscard decorations to base64 functions

The result of pg_b64_encode() and pg_b64_decode() should be checked
for errors.  This attribute could detect mistakes such as those fixed
in commit ff030ebe250 and d278541be42.

Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Ranier Vilela <ranier.vf@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CAEudQAq-3yHsSdWoOOaw%2BgAQYgPMpMGuB5pt2yCXgv-YuxG2Hg%40m...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b0eff1098860f88dd385e6882ff7b1063d267213

Modified Files
--------------
src/include/common/base64.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



Message-ID: <E1tYgmz-0022Qf-4r@gemulon.postgresql.org>
Permalink:  ../E1tYgmz-0022Qf-4r@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tYgmz-0022Qf-4r@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add pg_nodiscard decorations to base64 functions
  In-Reply-To: <E1tYgmz-0022Qf-4r@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox