pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Improve generated_stored test 2+ messages / 1 participants [nested] [flat]
* pgsql: Improve generated_stored test @ 2025-01-20 14:30 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2025-01-20 14:30 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve generated_stored test It makes more sense to put the catalog sanity check at the end of the test rather than at the beginning, so that it can also check whatever the tests did rather than just whatever happened before the tests. Suggested-by: jian he <jian.universality@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/a368248e-69e4-40be-9c07-6c3b5880b0a6@eisentraut.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/86749ea3b7660b09cfb951a253c24d2975f189f6 Modified Files -------------- src/test/regress/expected/generated_stored.out | 12 ++++++------ src/test/regress/sql/generated_stored.sql | 8 ++++---- 2 files changed, 10 insertions(+), 10 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Improve generated_stored test @ 2025-01-21 07:21 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2025-01-21 07:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve generated_stored test The test table names gtest11s and gtest12s were way originally chosen to signify "stored", when the idea was to have virtual columns in the same test file. This is no longer the idea, so this naming is irrelevant. (The upcoming feature of virtual generated columns will have a test file that is initially a copy of generated_stored.sql, and this random difference will be even more annoying then.) Clean this up by dropping the suffix. Discussion: https://www.postgresql.org/message-id/flat/a368248e-69e4-40be-9c07-6c3b5880b0a6@eisentraut.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/44b61efb7928a10e93408b374fa8df1effc8ef4c Modified Files -------------- src/test/regress/expected/generated_stored.out | 24 ++++++++++++------------ src/test/regress/sql/generated_stored.sql | 20 ++++++++++---------- 2 files changed, 22 insertions(+), 22 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-01-21 07:21 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-01-20 14:30 pgsql: Improve generated_stored test Peter Eisentraut <peter@eisentraut.org> 2025-01-21 07:21 pgsql: Improve generated_stored test Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox