pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve generated_stored test
Date: Mon, 20 Jan 2025 14:30:12 +0000
Message-ID: <E1tZsn6-002Yx0-3v@gemulon.postgresql.org> (raw)

Improve generated_stored test

It makes more sense to put the catalog sanity check at the end of the
test rather than at the beginning, so that it can also check whatever
the tests did rather than just whatever happened before the tests.

Suggested-by: jian he <jian.universality@gmail.com>

Discussion: https://www.postgresql.org/message-id/flat/a368248e-69e4-40be-9c07-6c3b5880b0a6@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/86749ea3b7660b09cfb951a253c24d2975f189f6

Modified Files
--------------
src/test/regress/expected/generated_stored.out | 12 ++++++------
src/test/regress/sql/generated_stored.sql      |  8 ++++----
2 files changed, 10 insertions(+), 10 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1tZsn6-002Yx0-3v@gemulon.postgresql.org>
Permalink:  ../E1tZsn6-002Yx0-3v@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1tZsn6-002Yx0-3v@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve generated_stored test
  In-Reply-To: <E1tZsn6-002Yx0-3v@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox