pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Reword recent error messages: "should" -> "must" 2+ messages / 1 participants [nested] [flat]
* pgsql: Reword recent error messages: "should" -> "must" @ 2025-01-21 14:30 Álvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 2+ messages in thread From: Álvaro Herrera @ 2025-01-21 14:30 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reword recent error messages: "should" -> "must" Most were introduced in the 17 timeframe. The ones in wparser_def.c are very old. I also changed "JSON path expression for column \"%s\" should return single item without wrapper" to "JSON path expression for column \"%s\" must return single item when no wrapper is requested" to avoid ambiguity. Backpatch to 17. Crickets: https://postgr.es/m/202501131819.26ors7oouafu@alvherre.pgsql Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/db19a5061ce954320f47a65c169081cbb2d920f8 Modified Files -------------- src/backend/tsearch/wparser_def.c | 8 ++++---- src/backend/utils/adt/jsonpath_exec.c | 12 ++++++------ src/test/regress/expected/sqljson_jsontable.out | 2 +- src/test/regress/expected/sqljson_queryfuncs.out | 8 ++++---- 4 files changed, 15 insertions(+), 15 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Reword recent error messages: "should" -> "must" @ 2025-01-21 14:30 Álvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 2+ messages in thread From: Álvaro Herrera @ 2025-01-21 14:30 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Reword recent error messages: "should" -> "must" Most were introduced in the 17 timeframe. The ones in wparser_def.c are very old. I also changed "JSON path expression for column \"%s\" should return single item without wrapper" to "JSON path expression for column \"%s\" must return single item when no wrapper is requested" to avoid ambiguity. Backpatch to 17. Crickets: https://postgr.es/m/202501131819.26ors7oouafu@alvherre.pgsql Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dbc3499a0bcb544d30ec4f6fe576b28ce0a7951f Modified Files -------------- src/backend/tsearch/wparser_def.c | 8 ++++---- src/backend/utils/adt/jsonpath_exec.c | 12 ++++++------ src/test/regress/expected/sqljson_jsontable.out | 2 +- src/test/regress/expected/sqljson_queryfuncs.out | 8 ++++---- 4 files changed, 15 insertions(+), 15 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-01-21 14:30 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-01-21 14:30 pgsql: Reword recent error messages: "should" -> "must" Álvaro Herrera <alvherre@alvh.no-ip.org> 2025-01-21 14:30 pgsql: Reword recent error messages: "should" -> "must" Álvaro Herrera <alvherre@alvh.no-ip.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox