From: Álvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reword recent error messages: "should" -> "must"
Date: Tue, 21 Jan 2025 14:30:49 +0000
Message-ID: <E1taFHF-002kZ4-3d@gemulon.postgresql.org> (raw)
Reword recent error messages: "should" -> "must"
Most were introduced in the 17 timeframe. The ones in wparser_def.c are
very old.
I also changed "JSON path expression for column \"%s\" should return
single item without wrapper" to "JSON path expression for column \"%s\"
must return single item when no wrapper is requested" to avoid
ambiguity.
Backpatch to 17.
Crickets: https://postgr.es/m/202501131819.26ors7oouafu@alvherre.pgsql
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/db19a5061ce954320f47a65c169081cbb2d920f8
Modified Files
--------------
src/backend/tsearch/wparser_def.c | 8 ++++----
src/backend/utils/adt/jsonpath_exec.c | 12 ++++++------
src/test/regress/expected/sqljson_jsontable.out | 2 +-
src/test/regress/expected/sqljson_queryfuncs.out | 8 ++++----
4 files changed, 15 insertions(+), 15 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Reword recent error messages: "should" -> "must"
In-Reply-To: <E1taFHF-002kZ4-3d@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox